Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-22 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1959783233 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-22 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1959404419 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
huangzhaobo99 commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1958556471 Pipeline failed, but the local env launched docker image was successfully built and compiled. cc @tasanuma 1. Install Docker and run this command: ``` ./start-build-env.sh

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957664677 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957645773 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957424893 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957214381 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957114687 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957048566 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
huangzhaobo99 commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957044724 @tasanuma Have completed, Whether or not need to modify the PR title? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957037784 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
huangzhaobo99 commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1956867368 @tasanuma Thanks for the reminder. I will complete it after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
tasanuma commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1956849499 @huangzhaobo99 Thanks for updating it, but there are still many mentions of Protocol Buffers 3.7.1 in BUILDING.txt. If we want to update all them to version 3.21.12, we firstly need to up

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
huangzhaobo99 commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1956774830 > Although I'm not an expert in curl, I believe this change is fine as it aligns with the instruction for CMake. However, in the first place, protobuf 3.7.1 could be outdated. We hav

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
tasanuma commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1956740552 Although I'm not an expert in curl, I believe this change is fine as it aligns with the instruction for CMake. However, in the first place, protobuf 3.7.1 could be outdated. We have start

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-19 Thread via GitHub
huangzhaobo99 commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1952301101 Hi @tasanuma Can you help me review it? Thanks. Thanks @steveloughran. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-03 Thread via GitHub
steveloughran commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1925344460 someone who knows curl better than me will need to review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-03 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1925271499 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-03 Thread via GitHub
huangzhaobo99 opened a new pull request, #6526: URL: https://github.com/apache/hadoop/pull/6526 ### Description of PR JIRA: https://issues.apache.org/jira/browse/HADOOP-19065 1. When downloading 'Protocol Buffers', there is no progress bar, Not very friendly for users. 2. The termin