Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-26 Thread via GitHub
huangzhaobo99 commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1965620933 > @huangzhaobo99 Thanks for the contribution! @steveloughran Thanks for the review! @slfan1989 Thanks for your verification and merging work, @steveloughran Thanks for your re

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-26 Thread via GitHub
slfan1989 commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1964331064 @huangzhaobo99 Thanks for the contribution! @steveloughran Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-26 Thread via GitHub
slfan1989 merged PR #6576: URL: https://github.com/apache/hadoop/pull/6576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-23 Thread via GitHub
steveloughran commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1961748672 I've created https://issues.apache.org/jira/browse/HADOOP-19087 as the JIRA for follow-on stuff for 3.4.1, which is going to mainly be packaging/jar changes. let's target that one wi

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-23 Thread via GitHub
steveloughran commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1961725347 I concur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-22 Thread via GitHub
slfan1989 commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1960754327 While I'd like to do this after releasing hadoop-3.4.0, @tasanuma makes a valid point. Since we already support protobuf 3.21.12 in hadoop-thirdparty 1.2.0, we should try to make this c

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-22 Thread via GitHub
slfan1989 commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1960750221 > I temporarily don't support porting this to the [hadoop-3](https://issues.apache.org/jira/browse/HADOOP-3).4.0 branch. I've spent a lot of time setting up the compilation environment,

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-22 Thread via GitHub
huangzhaobo99 commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1960749738 > > @slfan1989 Discussed in JIRA: https://issues.apache.org/jira/browse/HADOOP-19065 cc @steveloughran > > I temporarily don't support porting this to the [hadoop-3](https://i

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-22 Thread via GitHub
slfan1989 commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1960740564 > @slfan1989 Discussed in JIRA: https://issues.apache.org/jira/browse/HADOOP-19065 cc @steveloughran I temporarily don't support porting this to the hadoop-3.4.0 branch. I've spen

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-22 Thread via GitHub
huangzhaobo99 commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1960738479 > -1 > > You don't need to submit such changes. After the release of [hadoop-3](https://issues.apache.org/jira/browse/HADOOP-3).4.0, I will uniformly adjust the release compil

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-22 Thread via GitHub
slfan1989 commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1960734820 You don't need to submit such changes. After the release of hadoop-3.4.0, I will uniformly adjust the release compilation script. -- This is an automated message from the Apache Git Se

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-22 Thread via GitHub
hadoop-yetus commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1960717190 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-22 Thread via GitHub
hadoop-yetus commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1960716062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-22 Thread via GitHub
huangzhaobo99 commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1960655451 Message error, pushed twice, ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HADOOP-19065. Update Protocol Buffers installation to 3.21.12 [hadoop]

2024-02-22 Thread via GitHub
hadoop-yetus commented on PR #6576: URL: https://github.com/apache/hadoop/pull/6576#issuecomment-1960647331 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job