slfan1989 commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2155840850
Sorry for not following up on this PR promptly. I didn't run the full suite
of unit tests but relied on the original CI results. To ensure the next upgrade
goes smoothly, I'll run the
ayushtkn commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2082356393
The build results aren't good
https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1573/testReport/
some 12K tests vanished
ayushtkn commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2080554036
@slfan1989 did we had a test run in any of the build results? what changed
from the previous commit, I doubt we won't land up getting the same issues that
were present earlier? the last
slfan1989 commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2080544456
@steveloughran @ayushtkn Thanks for reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
slfan1989 merged PR #6664:
URL: https://github.com/apache/hadoop/pull/6664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #6545:
URL: https://github.com/apache/hadoop/pull/6545#issuecomment-2076895892
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6545:
URL: https://github.com/apache/hadoop/pull/6545#issuecomment-2076298066
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
hadoop-yetus commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2075039871
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2074275818
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
steveloughran commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2046049570
I'm happy with the last change, lets see what yetus says. I propose getting
it into trunk and waiting about a week before backporting, just so it's easier
to roll back if there are
ayushtkn commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2041397956
get a test run on the build, the last yetus report didn't do that. touch
something on the root pom & it should do the trick I believe
--
This is an automated message from the Apache
slfan1989 commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2041393461
@steveloughran @ayushtkn The compilation report looks as expected. May I
continue with something else?
--
This is an automated message from the Apache Git Service.
To respond to the
hadoop-yetus commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2040211693
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2039947474
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
slfan1989 commented on code in PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#discussion_r1552596574
##
hadoop-project/pom.xml:
##
@@ -2414,6 +2415,7 @@
false
${surefire.fork.timeout}
+
${surefire.module.config}
Review
ayushtkn commented on code in PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#discussion_r1551740904
##
hadoop-project/pom.xml:
##
@@ -2414,6 +2415,7 @@
false
${surefire.fork.timeout}
+
${surefire.module.config}
Review
steveloughran commented on code in PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#discussion_r1551706643
##
hadoop-project/pom.xml:
##
@@ -221,6 +221,7 @@
v1.22.5
1.10.13
1.20
+
-Dsurefire.failIfNoSpecifiedTests=false
Review Comment:
not
hadoop-yetus commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2036883281
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2036694345
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
slfan1989 commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2035808292
> * I'd like not failing if tests aren't provided to be the default
> * some surefire releases don't print stack traces by default. We need
that...let's make sure that option is set
steveloughran commented on code in PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#discussion_r1550082590
##
dev-support/bin/hadoop.sh:
##
@@ -614,7 +615,7 @@ function shadedclient_rebuild
echo_and_redirect "${logfile}" \
"${MAVEN}" "${MAVEN_ARGS[@]}" verify
slfan1989 commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2030867204
@ayushtkn @steveloughran I still want to upgrade this plugin to a higher
version. I'm not sure why the number of running unit tests is decreasing.
--
This is an automated message
hadoop-yetus commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2022093036
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on code in PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#discussion_r1540513670
##
dev-support/bin/hadoop.sh:
##
@@ -614,7 +615,7 @@ function shadedclient_rebuild
echo_and_redirect "${logfile}" \
"${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae
slfan1989 commented on code in PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#discussion_r1540513670
##
dev-support/bin/hadoop.sh:
##
@@ -614,7 +615,7 @@ function shadedclient_rebuild
echo_and_redirect "${logfile}" \
"${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae
hadoop-yetus commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2022007319
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
hadoop-yetus commented on PR #6664:
URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2016658334
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 opened a new pull request, #6664:
URL: https://github.com/apache/hadoop/pull/6664
### Description of PR
JIRA: HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5.
### How was this patch tested?
### For code changes:
- [ ] Does
steveloughran commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1961569379
pity. I do think those failures need to be addressed, as they are less test
runner problems than brittle tests *which will need to be fixed eventually*
--
This is an automated
slfan1989 commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1960795762
@shahrs87 I rolled back #6537. If you have any questions, feel free to
contact me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
slfan1989 commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1960784052
@ayushtkn @tasanuma @steveloughran
I don't want to roll back this change. I would like to continue pushing for
this upgrade. I have noticed several pull requests that seem to
ayushtkn commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1959710836
@tasanuma that problem is there even before this, I had a ticket:
[HADOOP-18701](https://issues.apache.org/jira/browse/HADOOP-18701), and was
trying to handle that along with several
tasanuma commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1959698960
There is another problem. After this PR, running any unit test using `mvn
test` from the command line has always resulted in a failure.
```
$ mvn test -Dtest=TestCacheDirectives
slfan1989 commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1959571283
I have carefully read the comments above. Some unit tests reported errors.
We need to re-modify the unit tests. I will actively participate in the
modification of this part.
cc:
slfan1989 commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1959545723
@shahrs87 I agree to revert this PR. I've noticed several PRs failing to
compile, which is concerning.
I will continue to follow up on updating the maven-surefire-plugin; indeed,
shahrs87 commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1957394370
Thank you @steveloughran for your response.
> Rather than say "hey, let's revert", I'd propose a "surefire update
triggers test failures" and see what can be done about addressing
ayushtkn commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1956562170
& some are failing due to protobuf upgrade as part of hadoop thirdparty
upgrade, I am checking all the HDFS tests, but little slowly
ayushtkn commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1956558036
Some tests are getting skipped as well as I mentioned on the jira
steveloughran commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1956544980
This is not good.
But looking at the failures I don't know whether to categorise as "test
runner regression" or "brittle tests failing under new test runner".
Here are
shahrs87 commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1954917172
Hi @slfan1989 @steveloughran
I am seeing test failures in `TestCacheDirectives, TestBlockReportLease` in
the daily build after this PR.
First build after merging this PR
slfan1989 merged PR #6537:
URL: https://github.com/apache/hadoop/pull/6537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
slfan1989 commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1937354924
@steveloughran Thank you for reviewing the code! I will merge this PR into
the trunk branch and continue to progress with the work to support Java 17
compilation.
--
This is an
hadoop-yetus commented on PR #6545:
URL: https://github.com/apache/hadoop/pull/6545#issuecomment-1936809566
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6545:
URL: https://github.com/apache/hadoop/pull/6545#issuecomment-1936757691
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
slfan1989 opened a new pull request, #6545:
URL: https://github.com/apache/hadoop/pull/6545
### Description of PR
JIRA: HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5.
### How was this patch tested?
### For code changes:
- [ ] Does
slfan1989 commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1936744038
> +1 for the change on trunk/3.4; let's see what surprises surface...we only
need to worry about build time issues, not production ones.
I will submit a pull request to trunk3.4
46 matches
Mail list logo
