Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-11 Thread via GitHub
zhangshuyan0 commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1988074249 @pjfanning Thanks for your reply. The reason I couldn't compile successfully was due to my local network problem. -- This is an automated message from the Apache Git Service. To res

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-11 Thread via GitHub
pjfanning commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1987788628 @zhangshuyan0 it is in the Apache Snapshot repo. See the version number: 1.3.0-SNAPHOT. See https://repository.apache.org/content/groups/snapshots/org/apache/hadoop/thirdparty/had

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-10 Thread via GitHub
zhangshuyan0 commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1987627731 It seems that `hadoop-shaded-protobuf_3_23` has not been deployed to the maven central repository yet. I cannot compile trunk with the latest code now. @pjfanning -- This is an a

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-08 Thread via GitHub
pjfanning commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1986438599 > are we up to date with other dependencies for a new thirdparty release? we should really bump them all up and then rebuild it. this isn't targeting 3.4.0 so not a blocker there

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-08 Thread via GitHub
steveloughran commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1986430725 are we up to date with other dependencies for a new thirdparty release? we should really bump them all up and then rebuild it. this isn't targeting 3.4.0 so not a blocker there

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-08 Thread via GitHub
pjfanning commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1985710340 @steveloughran this PR depends on a snapshot version of hadoop-thirdparty. Can we do a release of hadoop-thirdparty and then backport the uptake of the future hadoop-thirdparty release t

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-08 Thread via GitHub
steveloughran commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1985647257 we ready to get this into branch-3.4? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-07 Thread via GitHub
ayushtkn merged PR #6593: URL: https://github.com/apache/hadoop/pull/6593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-06 Thread via GitHub
pjfanning commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1981822779 Some of the test issues relate to `java.lang.OutOfMemoryError: unable to create new native thread` ``` [ERROR] Tests run: 10, Failures: 0, Errors: 5, Skipped: 0, Time elapsed:

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1981753960 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-06 Thread via GitHub
pjfanning commented on code in PR #6593: URL: https://github.com/apache/hadoop/pull/6593#discussion_r1514120462 ## pom.xml: ## @@ -57,6 +57,13 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x ${distMgmtSnapshotsName} ${distMgmtSn

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-05 Thread via GitHub
ayushtkn commented on code in PR #6593: URL: https://github.com/apache/hadoop/pull/6593#discussion_r1513863738 ## pom.xml: ## @@ -57,6 +57,13 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x ${distMgmtSnapshotsName} ${distMgmtSna

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-05 Thread via GitHub
hadoop-yetus commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1980121185 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-05 Thread via GitHub
Hexiaoqiao commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1978826022 Thanks @pjfanning . LGTM. Let's wait what CI will say. Try link to https://github.com/apache/hadoop-thirdparty/pull/34 -- This is an automated message from the Apache Git Service. T

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-05 Thread via GitHub
pjfanning commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1978626080 Switched PR to use the Apache snapshot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4 [hadoop-thirdparty]

2024-02-28 Thread via GitHub
steveloughran commented on PR #34: URL: https://github.com/apache/hadoop-thirdparty/pull/34#issuecomment-1968986534 actually, just reset the branch to HEAD^ to lose the license change; force pushed it (!). need to update site docs too, see. will do a proper PR -- This is an automated mess

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4 [hadoop-thirdparty]

2024-02-28 Thread via GitHub
steveloughran commented on PR #34: URL: https://github.com/apache/hadoop-thirdparty/pull/34#issuecomment-1968979867 merged. Then had to do a quick followup patch (same JIRA) to update the LICENSE-binary file. Thought that was easier than doing a revert, cherrypick with the license patch etc

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4 [hadoop-thirdparty]

2024-02-28 Thread via GitHub
steveloughran merged PR #34: URL: https://github.com/apache/hadoop-thirdparty/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsu

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-27 Thread via GitHub
ayushtkn commented on code in PR #6593: URL: https://github.com/apache/hadoop/pull/6593#discussion_r1504679035 ## hadoop-project/pom.xml: ## @@ -93,11 +93,11 @@ ${common.protobuf2.scope} -3.21.12 +3.23.4 Review Comment: this is correct, you need to

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4 [hadoop-thirdparty]

2024-02-27 Thread via GitHub
pjfanning commented on PR #34: URL: https://github.com/apache/hadoop-thirdparty/pull/34#issuecomment-1966522150 @steveloughran do you have the permissions to rerun the CI build? - I think it was just a download issue This update looks promising - see https://github.com/apache/hadoop/

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-27 Thread via GitHub
pjfanning commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1966519899 The 1 broken test seems unrelated: ``` [ERROR] org.apache.hadoop.hdfs.server.namenode.TestSecureNameNode Time elapsed: 1.417 s <<< ERROR! org.apache.kerby.kerberos.kerb.Krb

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-27 Thread via GitHub
pjfanning commented on code in PR #6593: URL: https://github.com/apache/hadoop/pull/6593#discussion_r1504072883 ## hadoop-project/pom.xml: ## @@ -93,11 +93,11 @@ ${common.protobuf2.scope} -3.21.12 +3.23.4 Review Comment: this value is the one used b

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1966336761 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-27 Thread via GitHub
steveloughran commented on code in PR #6593: URL: https://github.com/apache/hadoop/pull/6593#discussion_r1504069368 ## hadoop-project/pom.xml: ## @@ -93,11 +93,11 @@ ${common.protobuf2.scope} -3.21.12 +3.23.4 Review Comment: I'd prefer editing hadoo

[PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-02-26 Thread via GitHub
pjfanning opened a new pull request, #6593: URL: https://github.com/apache/hadoop/pull/6593 ### Description of PR DRAFT - See HADOOP-19090 The hadoop-thirdparty change is not merged yet so I am temporarily testing with a snapshot that I published with my groupId.

[PR] HADOOP-19090. Use protobuf-java 3.23.4 [hadoop-thirdparty]

2024-02-26 Thread via GitHub
pjfanning opened a new pull request, #34: URL: https://github.com/apache/hadoop-thirdparty/pull/34 See HADOOP-19090 - this is still WIP and needs testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov