Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-09-23 Thread via GitHub
anujmodi2021 commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2367489559 Hi @steveloughran Please check my comment on the merged commit. https://github.com/apache/hadoop/commit/55a576906dda00a04be1f13ed7f61e32ef73e309#r147058497 Sorry I should

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-08-14 Thread via GitHub
steveloughran merged PR #6686: URL: https://github.com/apache/hadoop/pull/6686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-08-14 Thread via GitHub
steveloughran commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2288394801 > fs.capability.virtual.block.locations it's to say "this fs makes up block locations". it means that cost of looking up block locations is a lot less (no remote calls) and you

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-08-13 Thread via GitHub
steveloughran commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2285944935 All checkstyles are from underscores; I tried to set up a style rule to disable this but it didn't work right as there's no checkstyle overrides in hadoop-common right now -- This

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-08-12 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2285266944 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-08-07 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2274693015 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-08-07 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2274465322 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-08-02 Thread via GitHub
steveloughran commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2265514623 legitimate failure ``` Expected to find '404' but got unexpected exception: java.io.UncheckedIOException: java.io.FileNotFoundException: missing at org.apache.hadoop.util.

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-07-29 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2256680451 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-07-29 Thread via GitHub
steveloughran commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2255806509 javadocs ``` hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FunctionalIO.java:83: warning: no @param for ``` checkstyles are all

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-07-26 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2253690393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-07-17 Thread via GitHub
steveloughran commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2234067389 test failure is `org.apache.hadoop.hdfs.server.namenode.TestFSNamesystemLockReport.test` -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-07-16 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2231975077 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-07-15 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2229891257 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-07-15 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2229788587 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-06-22 Thread via GitHub
steveloughran commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2182998675 thread memory problems triggering test failures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-06-14 Thread via GitHub
steveloughran commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2167755338 see also #6885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2167030549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-06-13 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2167027183 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-06-12 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2164165233 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-06-11 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2162046466 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-06-11 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2161568021 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-06-10 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2159573294 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-05-29 Thread via GitHub
steveloughran commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2137938767 @mukund-thakur this pr renames `bulkDelete_PageSize` to `bulkDelete_pageSize` to be consistent with everything else. My iceberg PR https://github.com/apache/iceberg/pull/10233

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-05-29 Thread via GitHub
steveloughran commented on code in PR #6686: URL: https://github.com/apache/hadoop/pull/6686#discussion_r1619247570 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Options.java: ## @@ -628,13 +654,17 @@ private OpenFileOptions() { public static fin

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2102654014 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-05-02 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2091578654 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2078260697 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2078260263 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2073589561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2047848306 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-08 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2043698412 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-05 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2040499224 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-02 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2033262547 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-02 Thread via GitHub
steveloughran commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2032833166 prepared parquet for this by renaming vectorio package to `org.apache.parquet.hadoop.util.wrappedio` -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-03-28 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2026084008 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe