Hexiaoqiao commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2336603872
> > Not see any place marked 3.4.2, would you mind to confirm? Thanks.
>
> branch-3.4 is going to be where 3.4.2 is going to be forked from -if you
do a PR for that branch it'll b
kevincai commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2327683039
> > > Committed to trunk. Thanks @kevincai for your contributions!
> > > BTW, what's your JIRA account? When I want to assign
https://issues.apache.org/jira/browse/HDFS-16084 to you but
Hexiaoqiao commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2325527015
> > Committed to trunk. Thanks @kevincai for your contributions!
> > BTW, what's your JIRA account? When I want to assign
https://issues.apache.org/jira/browse/HDFS-16084 to you but I
Hexiaoqiao commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2325525755
@steveloughran No plan to backport to other active branches if no more
requirement.
> so target 3.4.2?
Not see any place marked 3.4.2, would you mind to confirm? Thanks.
steveloughran commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2316113232
@Hexiaoqiao you want to get into hadoop branch 3.4, so target 3.4.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kevincai commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2314310318
> Committed to trunk. Thanks @kevincai for your contributions!
>
> BTW, what's your JIRA account? When I want to assign
https://issues.apache.org/jira/browse/HDFS-16084 to you but I
Hexiaoqiao commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2308738326
Committed to trunk. Thanks @kevincai for your contributions!
BTW, what's your JIRA account? When I want to assign
https://issues.apache.org/jira/browse/HDFS-16084 to you but I am
Hexiaoqiao merged PR #6969:
URL: https://github.com/apache/hadoop/pull/6969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@ha
kevincai commented on code in PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#discussion_r1721198372
##
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/libhdfs_getjni_test.cc:
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Fo
kevincai commented on code in PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#discussion_r1721200295
##
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/jni_helper.c:
##
@@ -818,26 +818,31 @@ JNIEnv* getJNIEnv(void)
fprintf(stderr, "getJNIEn
kevincai commented on code in PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#discussion_r1721198372
##
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/libhdfs_getjni_test.cc:
##
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Fo
Hexiaoqiao commented on code in PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#discussion_r1720949358
##
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/jni_helper.c:
##
@@ -818,26 +818,31 @@ JNIEnv* getJNIEnv(void)
fprintf(stderr, "getJNI
kevincai commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2272461912
Finally, the ci check passed
@zhengchenyu @tomscut whom else shall be invited to review this pull request?
--
This is an automated message from the Apache Git Service.
To respond
hadoop-yetus commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2272457127
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2272384734
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2272307000
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2272206426
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2271881830
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2270539057
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2270316726
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2270194562
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2270037531
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
tomscut commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2268043197
> > > saw the docker CI failed, am I doing something wrong?
> >
> >
> > I found that yasm download address changed. See #6973 for more
information.
>
> guess I should wait
kevincai commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2265813792
> > saw the docker CI failed, am I doing something wrong?
>
> I found that yasm download address changed. See #6973 for more information.
guess I should wait for your PR merge
zhengchenyu commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2265095776
> saw the docker CI failed, am I doing something wrong?
I found that yasm download address changed. See
https://github.com/apache/hadoop/pull/6973 for more information.
--
Thi
kevincai commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2261684907
saw the docker CI failed, am I doing something wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
hadoop-yetus commented on PR #6969:
URL: https://github.com/apache/hadoop/pull/6969#issuecomment-2261676667
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
kevincai opened a new pull request, #6969:
URL: https://github.com/apache/hadoop/pull/6969
### Description of PR
the jni state tls object is set before passing all the checks, resulting an
invalid state in the tls and been hit later on with invalid object which
already destro
28 matches
Mail list logo
