Hexiaoqiao commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2245176501
Committed to trunk. Thanks @aswinmprabhu for your works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Hexiaoqiao merged PR #6925:
URL: https://github.com/apache/hadoop/pull/6925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aswinmprabhu commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2245100184
Thanks, @Hexiaoqiao for the approval. Can we merge at the end of today?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hadoop-yetus commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2239846403
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
aswinmprabhu commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2239198521
@Hexiaoqiao can you please take a look again? I've replied and updated the
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
hadoop-yetus commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2238907467
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2236281671
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
aswinmprabhu commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2233951536
Hey @Hexiaoqiao, thanks a lot for the review!
Can you please help me understand why the TestJournalSync unit tests run by
the CI system fail? Because I am not able to replicate
hadoop-yetus commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2233036781
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
aswinmprabhu commented on code in PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#discussion_r1680471030
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNodeRpcServer.java:
##
@@ -245,17 +246,24 @@ public
aswinmprabhu commented on code in PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#discussion_r1680426413
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNodeSyncer.java:
##
@@ -187,7 +198,15 @@ private void
Hexiaoqiao commented on code in PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#discussion_r1679405906
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNodeSyncer.java:
##
@@ -187,7 +198,15 @@ private void
hadoop-yetus commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2227532764
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2226577872
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2220859545
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6925:
URL: https://github.com/apache/hadoop/pull/6925#issuecomment-2209272300
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
aswinmprabhu opened a new pull request, #6925:
URL: https://github.com/apache/hadoop/pull/6925
### Description of PR
If an unformatted JournalNode is added to an existing JournalNode set --
1. JournalNodeSyncer is unable to sync from the other JNs to this new JN
2. Namenode
17 matches
Mail list logo
