hadoop-yetus commented on PR #5597:
URL: https://github.com/apache/hadoop/pull/5597#issuecomment-2103362606
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks _
huangzhaobo99 commented on code in PR #5597:
URL: https://github.com/apache/hadoop/pull/5597#discussion_r1582490565
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##
@@ -2630,6 +2631,28 @@ public int getActiveTransferThread
hfutatzhanghb commented on PR #5597:
URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1855265316
https://github.com/apache/hadoop/assets/25115709/0f35d396-6754-4a3d-b65a-a8d8d9fc0ed8";>
almost 60k+ on another datanode.
--
This is an automated message from the Apache Git Serv
hfutatzhanghb commented on PR #5597:
URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1855260225
@ayushtkn @Hexiaoqiao @tomscut Hi, sir. I think we should better push this
PR forward. Because it waste datanode's memory. As the below screeshot show ,
it has 27K networkError key
hadoop-yetus commented on PR #5597:
URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1752006095
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hfutatzhanghb commented on PR #5597:
URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1751901214
> Instead of creating two separate classes for the unit test, we can just
put the unit tests in `TestDataNodeMetrics`.
@tomscut Sir, thanks a lot for your opinion, have try tha
hfutatzhanghb commented on PR #5597:
URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1751586724
@ayushtkn Sir, could you please help me review this PR again when have free
time? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
hadoop-yetus commented on PR #5597:
URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1742662247
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
