Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-05 Thread via GitHub
haiyang1987 commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1794097689 Thanks @Hexiaoqiao @zhangshuyan0 @tomscut for you review and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-05 Thread via GitHub
zhangshuyan0 commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1794026151 Committed to trunk. Thanks for your work @haiyang1987 @tomscut @Hexiaoqiao . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-05 Thread via GitHub
zhangshuyan0 merged PR #6238: URL: https://github.com/apache/hadoop/pull/6238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-02 Thread via GitHub
haiyang1987 commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1790321640 Test failures seems unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-02 Thread via GitHub
haiyang1987 commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1790321064 > LGTM. +1 from my side. But some CI result seems error now. Trigger Yetus manually, Let's wait what will it say. Thanks @Hexiaoqiao for your review. -- This is an automated m

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-02 Thread via GitHub
hadoop-yetus commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1790303832 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-01 Thread via GitHub
Hexiaoqiao commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-179145 LGTM. +1 from my side. But some CI result seems error now. Trigger Yetus manually, Let's wait what will it say. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-10-31 Thread via GitHub
haiyang1987 commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1788291174 > LGTM. Thanks @tomscut for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-10-31 Thread via GitHub
haiyang1987 commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1786850879 Hi @Hexiaoqiao @ayushtkn @ZanderXu @zhangshuyan0 Could you please help review this pr when you have free time. Thanks~ -- This is an automated message from the Apache Git Service.

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-10-30 Thread via GitHub
hadoop-yetus commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1785692146 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-10-30 Thread via GitHub
hadoop-yetus commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1785361779 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-10-30 Thread via GitHub
haiyang1987 opened a new pull request, #6238: URL: https://github.com/apache/hadoop/pull/6238 ### Description of PR When Balancer is running, it is found that there are many logs, such as `INFO balancer.Dispatcher (Dispatcher.java:markMovedIfGoodBlock(306)) - No striped internal b