Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-30 Thread via GitHub
slfan1989 commented on PR #6291: URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1833926153 @LiuGuH Thank you for your contribution! @goiri @Hexiaoqiao Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-30 Thread via GitHub
slfan1989 merged PR #6291: URL: https://github.com/apache/hadoop/pull/6291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-30 Thread via GitHub
slfan1989 commented on PR #6291: URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1833894765 > Hi @slfan1989 , any more comments here? Thanks. @Hexiaoqiao LGTM +1, Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-29 Thread via GitHub
Hexiaoqiao commented on PR #6291: URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1831921651 Hi @slfan1989 , any more comments here? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-28 Thread via GitHub
hadoop-yetus commented on PR #6291: URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1831360476 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-28 Thread via GitHub
LiuGuH commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1408780398 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -227,6 +234,59 @@ public void

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-28 Thread via GitHub
LiuGuH commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1408780241 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -227,6 +234,59 @@ public void

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-28 Thread via GitHub
Hexiaoqiao commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1407882437 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -227,6 +234,59 @@ public void

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-27 Thread via GitHub
hadoop-yetus commented on PR #6291: URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1829026020 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-27 Thread via GitHub
LiuGuH commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1406987425 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -227,6 +234,61 @@ public void

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-27 Thread via GitHub
Hexiaoqiao commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1406206626 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -227,6 +234,61 @@ public void

Re: [PR] HDFS-17263. RBF: Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-27 Thread via GitHub
slfan1989 commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1405853588 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -357,7 +357,7 @@ public void

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-24 Thread via GitHub
LiuGuH commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1404159749 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -357,7 +357,7 @@ public void

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-24 Thread via GitHub
LiuGuH commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1404159749 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -357,7 +357,7 @@ public void

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-24 Thread via GitHub
LiuGuH commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1402860528 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -357,7 +357,7 @@ public void

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-22 Thread via GitHub
LiuGuH commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1402860528 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -357,7 +357,7 @@ public void

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-22 Thread via GitHub
slfan1989 commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1401902539 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -357,7 +357,7 @@ public void

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6291: URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1822446504 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-22 Thread via GitHub
LiuGuH commented on PR #6291: URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1822312358 @zhuxiangyi @ferhui @goiri , Do you have time to review this? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-22 Thread via GitHub
LiuGuH opened a new pull request, #6291: URL: https://github.com/apache/hadoop/pull/6291 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub