Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-10 Thread via GitHub
ayushtkn merged PR #6319: URL: https://github.com/apache/hadoop/pull/6319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-06 Thread via GitHub
hadoop-yetus commented on PR #6319: URL: https://github.com/apache/hadoop/pull/6319#issuecomment-1842732133 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6319: URL: https://github.com/apache/hadoop/pull/6319#issuecomment-1840689287 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-05 Thread via GitHub
hadoop-yetus commented on PR #6319: URL: https://github.com/apache/hadoop/pull/6319#issuecomment-1840589906 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-05 Thread via GitHub
lfxy commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1415304496 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1346,9 +1376,9 @@ void printResults() { class

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-05 Thread via GitHub
ayushtkn commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1415282795 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1346,9 +1376,9 @@ void printResults() {

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-04 Thread via GitHub
lfxy commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1414958968 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1346,9 +1376,9 @@ void printResults() { class

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-04 Thread via GitHub
ayushtkn commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1414948378 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1346,9 +1376,9 @@ void printResults() {

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-04 Thread via GitHub
lfxy commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1414939112 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1346,9 +1376,9 @@ void printResults() { class

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-04 Thread via GitHub
lfxy commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1414931491 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1346,9 +1376,9 @@ void printResults() { class

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-04 Thread via GitHub
ayushtkn commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1414895365 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNNThroughputBenchmark.java: ## @@ -187,4 +187,60 @@ public void

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-04 Thread via GitHub
ayushtkn commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1414894665 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1346,9 +1376,9 @@ void printResults() {

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-04 Thread via GitHub
hadoop-yetus commented on PR #6319: URL: https://github.com/apache/hadoop/pull/6319#issuecomment-1838811180 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-04 Thread via GitHub
lfxy commented on PR #6319: URL: https://github.com/apache/hadoop/pull/6319#issuecomment-1838039895 @ayushtkn Thank you for your review. I have updated based on your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-03 Thread via GitHub
ayushtkn commented on code in PR #6319: URL: https://github.com/apache/hadoop/pull/6319#discussion_r1413157796 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -1348,7 +1363,7 @@ class ReplicationStats

Re: [PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-02 Thread via GitHub
hadoop-yetus commented on PR #6319: URL: https://github.com/apache/hadoop/pull/6319#issuecomment-1837250200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17272. NNThroughputBenchmark should support specifying the base directory for multi-client test [hadoop]

2023-12-02 Thread via GitHub
lfxy opened a new pull request, #6319: URL: https://github.com/apache/hadoop/pull/6319 Currently, NNThroughputBenchmark does not support specifying the base directory, therefore does not support multiple clients performing stress testing at the same time. However, for high-performance