simbadzina merged PR #6498:
URL: https://github.com/apache/hadoop/pull/6498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@ha
ThinkerLei commented on PR #6498:
URL: https://github.com/apache/hadoop/pull/6498#issuecomment-1931846902
@zhangshuyan0 @simbadzina Add a test case, please help to review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hadoop-yetus commented on PR #6498:
URL: https://github.com/apache/hadoop/pull/6498#issuecomment-1931819876
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
simbadzina commented on PR #6498:
URL: https://github.com/apache/hadoop/pull/6498#issuecomment-1912849626
Changes generally looks okay to me. Is this just an optimization to avoid
clearing a map which is empty, or there can be an error if we clear before the
router is in the RUNNING state.
ThinkerLei commented on PR #6498:
URL: https://github.com/apache/hadoop/pull/6498#issuecomment-1912000224
> The description of this PR is too vague to understand. Can you make it
clearer? By the way, a ut may be needed here.
Renew description and thanks a lot for your reply @zhangshuy
ThinkerLei commented on PR #6498:
URL: https://github.com/apache/hadoop/pull/6498#issuecomment-1909949829
@simbadzina @zhangshuyan0 anyone please help to review, thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
hadoop-yetus commented on PR #6498:
URL: https://github.com/apache/hadoop/pull/6498#issuecomment-1909456547
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
ThinkerLei opened a new pull request, #6498:
URL: https://github.com/apache/hadoop/pull/6498
We should start clear expired namespace thread at RouterRpcServer RUNNING
phase because StateStoreService is Initialized in initialization phase. Now,
router will throw IoException when start up.
