Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-02-18 Thread via GitHub
haiyang1987 commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1951692507 Thanks @tasanuma for your review and merge !!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-02-18 Thread via GitHub
tasanuma commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1951510529 Merged it. Thanks for your work, @haiyang1987! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-02-18 Thread via GitHub
tasanuma merged PR #6508: URL: https://github.com/apache/hadoop/pull/6508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-02-18 Thread via GitHub
tasanuma commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1951510077 The result of the CI is here. The failed tests seem not to be related. https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-6508/3/tests -- This is an

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-02-16 Thread via GitHub
haiyang1987 commented on code in PR #6508: URL: https://github.com/apache/hadoop/pull/6508#discussion_r1492085929 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/QueryCommand.java: ## @@ -56,52 +66,72 @@ public QueryCommand(Con

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-02-07 Thread via GitHub
tasanuma commented on code in PR #6508: URL: https://github.com/apache/hadoop/pull/6508#discussion_r1481790761 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/QueryCommand.java: ## @@ -56,52 +66,72 @@ public QueryCommand(Config

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-02-03 Thread via GitHub
haiyang1987 commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1925264228 Hi @zhangshuyan0 @ZanderXu @smarthanwang please help to push this modification forward If there are no any further comments. Thank you very much. -- This is an automated message from

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-02-03 Thread via GitHub
haiyang1987 commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1925260885 Hi @Hexiaoqiao @ZanderXu @zhangshuyan0 @tasanuma Could you mind help me review this PR when you have free time? Thanks~ -- This is an automated message from the Apache Git Service. T

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-01-29 Thread via GitHub
haiyang1987 commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1914512212 @Hexiaoqiao @ZanderXu @zhangshuyan0 @tasanuma can you please take a look at this PR when you have free time? Thanks~ -- This is an automated message from the Apache Git Service. To r

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-01-29 Thread via GitHub
haiyang1987 commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1914509936 The failed unit test seems unrelated to the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-01-29 Thread via GitHub
hadoop-yetus commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1914428268 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-01-28 Thread via GitHub
hadoop-yetus commented on PR #6508: URL: https://github.com/apache/hadoop/pull/6508#issuecomment-1913714510 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] HDFS-17361. DiskBalancer: Query command support with multiple nodes [hadoop]

2024-01-28 Thread via GitHub
haiyang1987 opened a new pull request, #6508: URL: https://github.com/apache/hadoop/pull/6508 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17361 For: https://issues.apache.org/jira/browse/HDFS-10821 mentioned, Query command will support with multiple nodes. T