zhengchenyu commented on PR #6762:
URL: https://github.com/apache/hadoop/pull/6762#issuecomment-2141744912
I know this PR is phase 1 work: split global lock into fslock and bmlock.
We should ensure the lock order: bmlock cannot occur in front of fslock. Can
we add some restrictions or che
zhengchenyu commented on code in PR #6762:
URL: https://github.com/apache/hadoop/pull/6762#discussion_r1622166340
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/fgl/FineGrainedFSNamesystemLock.java:
##
@@ -0,0 +1,300 @@
+/**
+ * Licensed
hadoop-yetus commented on PR #6762:
URL: https://github.com/apache/hadoop/pull/6762#issuecomment-2106553639
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| -1 :x: | patch
ZanderXu commented on code in PR #6762:
URL: https://github.com/apache/hadoop/pull/6762#discussion_r1591744778
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -6043,7 +6079,7 @@ void updatePipeline(
updatePi
ferhui commented on code in PR #6762:
URL: https://github.com/apache/hadoop/pull/6762#discussion_r1590192211
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -6043,7 +6079,7 @@ void updatePipeline(
updatePipe
hadoop-yetus commented on PR #6762:
URL: https://github.com/apache/hadoop/pull/6762#issuecomment-2081720138
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks
hfutatzhanghb commented on code in PR #6762:
URL: https://github.com/apache/hadoop/pull/6762#discussion_r1578763344
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -6043,7 +6079,7 @@ void updatePipeline(
upd
ZanderXu commented on PR #6762:
URL: https://github.com/apache/hadoop/pull/6762#issuecomment-2071967284
The spotbugs will be fixed by HDFS-17451. And the failed UT is not imported
by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
hadoop-yetus commented on PR #6762:
URL: https://github.com/apache/hadoop/pull/6762#issuecomment-2071959089
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
ZanderXu opened a new pull request, #6762:
URL: https://github.com/apache/hadoop/pull/6762
We plan to merge HDFS-17384 to the trunk branch.
This PR is used to review all changes in HDFS-17384.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
10 matches
Mail list logo