Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-23 Thread via GitHub
Hexiaoqiao commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-2016423251 Great. It's OK. Thanks @ThinkerLei for your works, will involve to review it in the next days. Thanks again. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-22 Thread via GitHub
ThinkerLei commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-2015079963 @Hexiaoqiao @dineshchitlangia @zhangshuyan0 @hfutatzhanghb I apologize for not being able to respond in a timely manner recently. Since there are some aspects of the current logic in

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-2013690866 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-21 Thread via GitHub
ThinkerLei closed pull request #6608: HDFS-17408. Reduce quota calculation times in FSDirRenameOp. URL: https://github.com/apache/hadoop/pull/6608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-2012579307 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-21 Thread via GitHub
zhangshuyan0 commented on code in PR #6608: URL: https://github.com/apache/hadoop/pull/6608#discussion_r1533779361 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java: ## @@ -88,13 +96,19 @@ private static void verifyQuotaFo

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1998128403 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-07 Thread via GitHub
ThinkerLei commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1984976217 > Hi @ThinkerLei , Please check if the failed unite tests are related with this changes. @Hexiaoqiao Thanks for your reply, I will work on this soon. -- This is an automated m

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1984973314 Hi @ThinkerLei , Please check if the failed unite tests are related with this changes. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1983825438 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1983018540 Some nit point: It will be helpful for reviewers when add some description about this improvement background and target. If offer benchmark result will be better. -- This is an autom

Re: [PR] HDFS-17408. Reduce quota calculation times in FSDirRenameOp. [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6608: URL: https://github.com/apache/hadoop/pull/6608#issuecomment-1983003619 Thanks @ThinkerLei for your works. It's great performance improvement! The last CI didn't run clean, try to trigger it again. Let's wait what it will say. -- This is an automated mess