Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-25 Thread via GitHub
ferhui commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2019288558 Merged. Thanks for contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-25 Thread via GitHub
ferhui merged PR #6647: URL: https://github.com/apache/hadoop/pull/6647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-25 Thread via GitHub
ZanderXu commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2019286270 @ferhui The failed UT `hadoop.hdfs.TestRollingUpgrade` works fine locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-25 Thread via GitHub
hadoop-yetus commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2018395188 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-25 Thread via GitHub
hadoop-yetus commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2018117162 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-23 Thread via GitHub
hadoop-yetus commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2016606935 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-22 Thread via GitHub
hadoop-yetus commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2015242951 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-22 Thread via GitHub
ZanderXu commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2014600094 The failed UT `hadoop.hdfs.server.namenode.fgl.TestFineGrainedFSNamesystemLock` can be ignored first. I will create a ticket to make this UT stronger. -- This is an automated m

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-22 Thread via GitHub
hadoop-yetus commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2014499170 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ZanderXu commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2014192895 > CI reported checkstyle issue. can also fix that. Thanks Done, please help me review it again, thanks -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2014172936 CI reported checkstyle issue. can also fix that. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
hadoop-yetus commented on PR #6647: URL: https://github.com/apache/hadoop/pull/6647#issuecomment-2011925968 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui commented on code in PR #6647: URL: https://github.com/apache/hadoop/pull/6647#discussion_r1533604421 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -5346,11 +5346,12 @@ NamenodeCommand startCheckpoint(Name

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ZanderXu commented on code in PR #6647: URL: https://github.com/apache/hadoop/pull/6647#discussion_r1533487337 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java: ## @@ -2150,7 +2155,7 @@ int computeReconstructionWork

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ZanderXu commented on code in PR #6647: URL: https://github.com/apache/hadoop/pull/6647#discussion_r1533484754 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -5346,11 +5346,12 @@ NamenodeCommand startCheckpoint(Na

Re: [PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-21 Thread via GitHub
ferhui commented on code in PR #6647: URL: https://github.com/apache/hadoop/pull/6647#discussion_r1533464091 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -5346,11 +5346,12 @@ NamenodeCommand startCheckpoint(Name

[PR] HDFS-17416. [FGL] Monitor threads in BlockManager.class support fine-grained lock [hadoop]

2024-03-20 Thread via GitHub
ZanderXu opened a new pull request, #6647: URL: https://github.com/apache/hadoop/pull/6647 Threads in BlockManager.class support fine-grained lock. - BlockReportProcessingThread - MarkedDeleteBlockScrubber - RedundancyMonitor - Reconstruction Queue Initializer Normally,