Re: [PR] HDFS-17456. Fix the dfsused statistics of datanode are incorrect when appending a file. [hadoop]

2024-04-28 Thread via GitHub
fuchaohong commented on PR #6713: URL: https://github.com/apache/hadoop/pull/6713#issuecomment-2081977865 > @fuchaohong Hi, IIUC the `dfsused` will be refreshed periodically. Do you meet any issues about this metric? Thanks. @Hexiaoqiao Indeed, the dfsused metric is corrected periodically

Re: [PR] HDFS-17456. Fix the dfsused statistics of datanode are incorrect when appending a file. [hadoop]

2024-04-28 Thread via GitHub
Hexiaoqiao commented on PR #6713: URL: https://github.com/apache/hadoop/pull/6713#issuecomment-2081850789 @fuchaohong Hi, IIUC the `dfsused` will be refreshed periodically. Do you meet any issues about this metric? Thanks. -- This is an automated message from the Apache Git Service. To re

Re: [PR] HDFS-17456. Fix the dfsused statistics of datanode are incorrect when appending a file. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6713: URL: https://github.com/apache/hadoop/pull/6713#issuecomment-2074088648 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17456. Fix the dfsused statistics of datanode are incorrect when appending a file. [hadoop]

2024-04-07 Thread via GitHub
hadoop-yetus commented on PR #6713: URL: https://github.com/apache/hadoop/pull/6713#issuecomment-2041485037 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17456. Fix the dfsused statistics of datanode are incorrect when appending a file. [hadoop]

2024-04-07 Thread via GitHub
hadoop-yetus commented on PR #6713: URL: https://github.com/apache/hadoop/pull/6713#issuecomment-2041467867 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17456. Fix the dfsused statistics of datanode are incorrect when appending a file. [hadoop]

2024-04-07 Thread via GitHub
fuchaohong commented on PR #6713: URL: https://github.com/apache/hadoop/pull/6713#issuecomment-2041384187 @ZanderXu done the describe, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HDFS-17456. Fix the dfsused statistics of datanode are incorrect when appending a file. [hadoop]

2024-04-07 Thread via GitHub
fuchaohong commented on code in PR #6713: URL: https://github.com/apache/hadoop/pull/6713#discussion_r1554843103 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java: ## @@ -1291,7 +1291,9 @@ public ReplicaInPip

Re: [PR] HDFS-17456. Fix the dfsused statistics of datanode are incorrect when appending a file. [hadoop]

2024-04-07 Thread via GitHub
ZanderXu commented on code in PR #6713: URL: https://github.com/apache/hadoop/pull/6713#discussion_r1554836176 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java: ## @@ -1291,7 +1291,9 @@ public ReplicaInPipel