Re: [PR] HDFS-17486. Unify the logic of the dumpXattrs method [hadoop]

2024-05-11 Thread via GitHub
YaAYadeer commented on PR #6797: URL: https://github.com/apache/hadoop/pull/6797#issuecomment-2105598177 The test class TestOfflineImageViewer already exists. TestOfflineImageViewer.testPBImageXmlWriter() method will call dumpXattrs when input parameter of dumpXattrs has xattrs. --

Re: [PR] HDFS-17486. Unify the logic of the dumpXattrs method [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6797: URL: https://github.com/apache/hadoop/pull/6797#issuecomment-2104197718 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17486. Unify the logic of the dumpXattrs method [hadoop]

2024-05-06 Thread via GitHub
hadoop-yetus commented on PR #6797: URL: https://github.com/apache/hadoop/pull/6797#issuecomment-2095333179 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17486. Unify the logic of the dumpXattrs method [hadoop]

2024-05-05 Thread via GitHub
YaAYadeer opened a new pull request, #6797: URL: https://github.com/apache/hadoop/pull/6797 ### Description of PR For more information about this PR, please refer to the following issue: [HDFS-17486] (https://issues.apache.org/jira/browse/HDFS-17486) VIO: dumpXattrs logic