Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-14 Thread via GitHub
simbadzina merged PR #6804: URL: https://github.com/apache/hadoop/pull/6804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-14 Thread via GitHub
simbadzina commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2110488809 Failing tests in continuous-integration unrelated to my changes ``` Failed junit tests | hadoop.hdfs.server.federation.router.security.token.TestSQLDelegationTokenSecretMana

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-14 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2109700134 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-13 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2109071666 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-13 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2109013347 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-13 Thread via GitHub
ctrezzo commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1599008233 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void update

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-13 Thread via GitHub
simbadzina commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1598782895 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void upd

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-13 Thread via GitHub
simbadzina commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2108218576 > @simbadzina Should we also add a test case to [TestPoolAlignmentContext.java](https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/h

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2105541751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-10 Thread via GitHub
ctrezzo commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1597137120 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void update

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-10 Thread via GitHub
ctrezzo commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1596090988 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void update

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2104652320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2104068739 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-09 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2103966017 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
simbadzina commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594952346 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void upd

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
simbadzina commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594952346 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void upd

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
xinglin commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594843688 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void update

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
simbadzina commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594514981 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void upd

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
xinglin commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594406970 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void update

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
mccormickt12 commented on code in PR #6804: URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594349582 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java: ## @@ -64,7 +64,11 @@ public void u

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2100903362 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2100275260 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
hadoop-yetus commented on PR #6804: URL: https://github.com/apache/hadoop/pull/6804#issuecomment-2100214644 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] HDFS-17514: RBF: Routers should unset cached stateID when namenode does not set stateID in RPC response header. [hadoop]

2024-05-08 Thread via GitHub
simbadzina opened a new pull request, #6804: URL: https://github.com/apache/hadoop/pull/6804 ### Description of PR When a namenode that had "dfs.namenode.state.context.enabled" set to true is restarted with the configuration set to false, routers will keep using a previously cach