hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1820696613
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1822155782
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1823806436
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
anmolanmol1234 commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1823838318
Hi @steveloughran, I have made the changes for shaded client checks that
were failing on the mockito upgrade. Requesting your review for the same.
--
This is an automated message
hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1824847734
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
anmolanmol1234 commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1831603487
> actually, I'm trying to understand this.
>
> > we changed the scope of the mockito-core dependency to compile.
>
> why do we need this? and why can't it just be marked
hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1832695256
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
saxenapranav commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1410207987
##
hadoop-project/pom.xml:
##
@@ -1288,10 +1288,22 @@
jackson-dataformat-cbor
${jackson2.version}
+
+org.mockito
+mo
steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1414155674
##
hadoop-project/pom.xml:
##
@@ -1288,10 +1288,22 @@
jackson-dataformat-cbor
${jackson2.version}
+
+org.mockito
+m
steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1414157394
##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-te
anmolanmol1234 commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1416850390
##
hadoop-project/pom.xml:
##
@@ -1288,10 +1288,22 @@
jackson-dataformat-cbor
${jackson2.version}
+
+org.mockito
+
anmolanmol1234 commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1416851730
##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-t
hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1843718075
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1419369703
##
hadoop-client-modules/hadoop-client-minicluster/pom.xml:
##
@@ -400,6 +400,7 @@
org.mockito
mockito-core
+ ${mockito.version}
Review C
saxenapranav commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1420202409
##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-tem
saxenapranav commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1420202409
##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-tem
steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1420352516
##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-te
steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1420351865
##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-te
hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1857019408
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
19 matches
Mail list logo
