Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

slfan1989 commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2143047654 @goiri Thank you very much for reviewing the code! I merged this pr into the trunk branch. The related compilation error has nothing to do with our code. -- This is an automated

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

slfan1989 merged PR #6795: URL: https://github.com/apache/hadoop/pull/6795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2115593583 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

slfan1989 commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2113650049 @goiri Can you help review this pr again? Thank you very much! The error reported by mvn compilation is not caused by our changes. -- This is an automated message from the Apache Git

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2112336237 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2108107635 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | -1 :x: | patch

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2107954804 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2107894913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

slfan1989 commented on code in PR #6795: URL: https://github.com/apache/hadoop/pull/6795#discussion_r1597873381 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/Federation.md: ## @@ -536,7 +536,7 @@ To enable cross-origin support (CORS) for the Yarn Router,

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

goiri commented on code in PR #6795: URL: https://github.com/apache/hadoop/pull/6795#discussion_r1597672074 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/Federation.md: ## @@ -536,7 +536,7 @@ To enable cross-origin support (CORS) for the Yarn Router,

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2105893097 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2105303552 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2103647255 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

hadoop-yetus commented on PR #6795: URL: https://github.com/apache/hadoop/pull/6795#issuecomment-2100562189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

slfan1989 commented on code in PR #6795: URL: https://github.com/apache/hadoop/pull/6795#discussion_r1590520965 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/cache/FederationCaffeineCache.java:

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

slfan1989 commented on code in PR #6795: URL: https://github.com/apache/hadoop/pull/6795#discussion_r1590520824 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/cache/FederationCaffeineCache.java:

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

goiri commented on code in PR #6795: URL: https://github.com/apache/hadoop/pull/6795#discussion_r1590365458 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/cache/FederationCaffeineCache.java: