Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-29 Thread via GitHub
slfan1989 commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1914714875 @yangjiandan Thanks for the contribution! merged into trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-29 Thread via GitHub
slfan1989 merged PR #6490: URL: https://github.com/apache/hadoop/pull/6490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-28 Thread via GitHub
hadoop-yetus commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1913991706 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-25 Thread via GitHub
slfan1989 commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1911516346 @yangjiandan Thanks for the contribution! let’s take a look at other partners’ suggestions. If there are no comments, we will merge this PR in 1 - 2 days. -- This is an automated mess

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-25 Thread via GitHub
yangjiandan commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1911328177 @slfan1989 Please help me review this patch again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-24 Thread via GitHub
hadoop-yetus commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1909580764 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-24 Thread via GitHub
yangjiandan commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1909291218 The compilation error for TestQueueCapacityConfigParser is introduced by YARN-11041. I file a issue YARN-11651 to fix. -- This is an automated message from the Apache Git Servic

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-24 Thread via GitHub
hadoop-yetus commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1909237131 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-24 Thread via GitHub
yangjiandan commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1907721619 Since there is no new or modified code, there is no need to add unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-23 Thread via GitHub
hadoop-yetus commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1907557480 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-23 Thread via GitHub
slfan1989 commented on PR #6490: URL: https://github.com/apache/hadoop/pull/6490#issuecomment-1907435637 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] YARN-11650. Refactoring variable names related multiNodePolicy in MultiNodePolicySpec, FiCaSchedulerApp and AbstractCSQueue [hadoop]

2024-01-23 Thread via GitHub
yangjiandan opened a new pull request, #6490: URL: https://github.com/apache/hadoop/pull/6490 … ### Description of PR see https://issues.apache.org/jira/browse/YARN-11650 ### How was this patch tested? ### For code changes: - [ ] Does the title or th