[jira] [Commented] (HADOOP-10632) Minor improvements to Crypto input and output streams

2014-05-30 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013403#comment-14013403 ] Yi Liu commented on HADOOP-10632: - Committed to branch. > Minor improvements to Crypto

[jira] [Commented] (HADOOP-10632) Minor improvements to Crypto input and output streams

2014-05-29 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013362#comment-14013362 ] Alejandro Abdelnur commented on HADOOP-10632: - +1 > Minor improvements to C

[jira] [Commented] (HADOOP-10632) Minor improvements to Crypto input and output streams

2014-05-29 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013248#comment-14013248 ] Alejandro Abdelnur commented on HADOOP-10632: - LGTM, +1 after the following

[jira] [Commented] (HADOOP-10632) Minor improvements to Crypto input and output streams

2014-05-29 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012621#comment-14012621 ] Alejandro Abdelnur commented on HADOOP-10632: - Yi, looks very good, also how

[jira] [Commented] (HADOOP-10632) Minor improvements to Crypto input and output streams

2014-05-28 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011509#comment-14011509 ] Alejandro Abdelnur commented on HADOOP-10632: - Also, the {{CryptoCodec}} has

[jira] [Commented] (HADOOP-10632) Minor improvements to Crypto input and output streams

2014-05-28 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011344#comment-14011344 ] Alejandro Abdelnur commented on HADOOP-10632: - Thanks Yi, looks good, a few

[jira] [Commented] (HADOOP-10632) Minor improvements to Crypto input and output streams

2014-05-27 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010793#comment-14010793 ] Yi Liu commented on HADOOP-10632: - Thanks [~tucu00], I will improve them and respond to

[jira] [Commented] (HADOOP-10632) Minor improvements to Crypto input and output streams

2014-05-27 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010753#comment-14010753 ] Alejandro Abdelnur commented on HADOOP-10632: - Yi, nice work. following some