[jira] [Commented] (HADOOP-11056) OsSecureRandom.setConf() might leak resource

2014-09-03 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120873#comment-14120873 ] Colin Patrick McCabe commented on HADOOP-11056: --- +1. Thanks, Yongjun. >

[jira] [Commented] (HADOOP-11056) OsSecureRandom.setConf() might leak resource

2014-09-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120688#comment-14120688 ] Hadoop QA commented on HADOOP-11056: {color:red}-1 overall{color}. Here are the res

[jira] [Commented] (HADOOP-11056) OsSecureRandom.setConf() might leak resource

2014-09-03 Thread Yongjun Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120619#comment-14120619 ] Yongjun Zhang commented on HADOOP-11056: HI [~cmccabe], thanks a lot for the rev

[jira] [Commented] (HADOOP-11056) OsSecureRandom.setConf() might leak resource

2014-09-03 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120369#comment-14120369 ] Colin Patrick McCabe commented on HADOOP-11056: --- {code} +if (stream !=

[jira] [Commented] (HADOOP-11056) OsSecureRandom.setConf() might leak resource

2014-09-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120179#comment-14120179 ] Hadoop QA commented on HADOOP-11056: {color:green}+1 overall{color}. Here are the r

[jira] [Commented] (HADOOP-11056) OsSecureRandom.setConf() might leak resource

2014-09-03 Thread Yongjun Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120109#comment-14120109 ] Yongjun Zhang commented on HADOOP-11056: BTW, The added test is for observation