[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356194#comment-15356194
]
Hadoop QA commented on HADOOP-12345:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355898#comment-15355898
]
Pradeep Nayak Udupi Kadbet commented on HADOOP-12345:
-
Cool. I have addressed your
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355577#comment-15355577
]
Andrew Wang commented on HADOOP-12345:
--
Looks good overall, few more nits:
* The "m" prefix on
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354214#comment-15354214
]
Hadoop QA commented on HADOOP-12345:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354184#comment-15354184
]
Pradeep Nayak Udupi Kadbet commented on HADOOP-12345:
-
I have attached the new
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353998#comment-15353998
]
Andrew Wang commented on HADOOP-12345:
--
I normally just review the patch on JIRA, so you can just
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353993#comment-15353993
]
Pradeep Nayak Udupi Kadbet commented on HADOOP-12345:
-
Ok, I will put the patch file
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353992#comment-15353992
]
Pradeep Nayak Udupi Kadbet commented on HADOOP-12345:
-
Oops! I meant to say len % 4
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353986#comment-15353986
]
Andrew Wang commented on HADOOP-12345:
--
Also, do you mind posting a patch here on JIRA? We use
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353974#comment-15353974
]
Andrew Wang commented on HADOOP-12345:
--
Looked at the PR. Can we add a test for the length % 4 == 0
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346906#comment-15346906
]
ASF GitHub Bot commented on HADOOP-12345:
-
GitHub user pradeep1288 opened a pull request:
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346877#comment-15346877
]
ASF GitHub Bot commented on HADOOP-12345:
-
Github user pradeep1288 closed the pull request at:
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346876#comment-15346876
]
ASF GitHub Bot commented on HADOOP-12345:
-
Github user pradeep1288 commented on the issue:
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346853#comment-15346853
]
Andrew Wang commented on HADOOP-12345:
--
Hi Pradeep,
Based on my recollection from reading the spec
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346835#comment-15346835
]
Pradeep Nayak Udupi Kadbet commented on HADOOP-12345:
-
Andrew -
You would need a
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346782#comment-15346782
]
Andrew Wang commented on HADOOP-12345:
--
Hi Pradeep, thanks for working on this,
Is it possible to
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344971#comment-15344971
]
Hadoop QA commented on HADOOP-12345:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344967#comment-15344967
]
ASF GitHub Bot commented on HADOOP-12345:
-
GitHub user pradeep1288 opened a pull request:
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256611#comment-15256611
]
Ray Chiang commented on HADOOP-12345:
-
Given that no patch has been submitted for 8 months, I'd
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153897#comment-15153897
]
Akira AJISAKA commented on HADOOP-12345:
Is there anyone working on this issue?
> Credential
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14951489#comment-14951489
]
S M Al Mamun commented on HADOOP-12345:
---
Is there anyone actively working on this? I was planning
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14951541#comment-14951541
]
UdupiKadbet, PradeepNayak commented on HADOOP-12345:
I am actually working on this
[
https://issues.apache.org/jira/browse/HADOOP-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14706001#comment-14706001
]
Chris Douglas commented on HADOOP-12345:
bq. I would be happy to submit the
23 matches
Mail list logo
