[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220811#comment-15220811 ] Hudson commented on HADOOP-12955: - FAILURE: Integrated in Hadoop-trunk-Commit #9538 (See

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220757#comment-15220757 ] Kai Zheng commented on HADOOP-12955: Thanks Colin for driving into this nice result

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220745#comment-15220745 ] Colin Patrick McCabe commented on HADOOP-12955: --- +1. Thanks, [~drankye].

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215926#comment-15215926 ] Kai Zheng commented on HADOOP-12955: The cc warning and test failures are not releva

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215896#comment-15215896 ] Hadoop QA commented on HADOOP-12955: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215209#comment-15215209 ] Kai Zheng commented on HADOOP-12955: bq. we wouldn't even need a getLibraryName func

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215201#comment-15215201 ] Kai Zheng commented on HADOOP-12955: bq. I think it would be safer to have the initi

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215195#comment-15215195 ] Colin Patrick McCabe commented on HADOOP-12955: --- In general, the other nat

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215194#comment-15215194 ] Kai Zheng commented on HADOOP-12955: bq. There needs to be a return null; here after

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215173#comment-15215173 ] Kai Zheng commented on HADOOP-12955: Thanks Colin! bq. There needs to be a return nu

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215162#comment-15215162 ] Colin Patrick McCabe commented on HADOOP-12955: --- {code} if (error != NUL

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213927#comment-15213927 ] Hadoop QA commented on HADOOP-12955: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213714#comment-15213714 ] Kai Zheng commented on HADOOP-12955: After looking into {{THROW}} and the question h

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212677#comment-15212677 ] Kai Zheng commented on HADOOP-12955: Thanks [~cmccabe] for the further helpful expla

[jira] [Commented] (HADOOP-12955) Fix bugs in the initialization of the ISA-L library JNI bindings

[ https://issues.apache.org/jira/browse/HADOOP-12955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212543#comment-15212543 ] Colin Patrick McCabe commented on HADOOP-12955: --- Thanks for the revisions.