[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431847#comment-15431847
]
Anu Engineer commented on HADOOP-13526:
---
+1, on patch 3. Thanks for the patch [~sa
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431820#comment-15431820
]
Xiao Chen commented on HADOOP-13526:
+1 on patch 3, will commit later today if no ob
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431803#comment-15431803
]
Hadoop QA commented on HADOOP-13526:
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431736#comment-15431736
]
Hadoop QA commented on HADOOP-13526:
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431706#comment-15431706
]
Hadoop QA commented on HADOOP-13526:
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431683#comment-15431683
]
Suraj Acharya commented on HADOOP-13526:
[~anu] and [~xiaochen]
Done :)
Sorry ab
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431667#comment-15431667
]
Xiao Chen commented on HADOOP-13526:
Hi Suraj,
Sorry for not being clear. The check
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431668#comment-15431668
]
Anu Engineer commented on HADOOP-13526:
---
There is one more checkstyle warning abou
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431664#comment-15431664
]
Suraj Acharya commented on HADOOP-13526:
I fixed it by declaring it as final as
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431638#comment-15431638
]
Xiao Chen commented on HADOOP-13526:
Thanks [~sacharya] for reporting and fixing the
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431560#comment-15431560
]
Anu Engineer commented on HADOOP-13526:
---
[~sacharya] Thanks for the explanation. T
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431543#comment-15431543
]
Suraj Acharya commented on HADOOP-13526:
@anu i tried to emulate the model prese
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431342#comment-15431342
]
Anu Engineer commented on HADOOP-13526:
---
[~sacharya] Thanks for catching this and
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429989#comment-15429989
]
Suraj Acharya commented on HADOOP-13526:
No tests have been added since it is an
[
https://issues.apache.org/jira/browse/HADOOP-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429988#comment-15429988
]
Hadoop QA commented on HADOOP-13526:
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
15 matches
Mail list logo