[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746528#comment-15746528
]
Jason Lowe commented on HADOOP-13709:
-
+1 lgtm. Committing this.
> Clean up subprocesses spawned
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745995#comment-15745995
]
Eric Badger commented on HADOOP-13709:
--
The test failures are related to HADOOP-13890/HADOOP-13565
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743322#comment-15743322
]
Hadoop QA commented on HADOOP-13709:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743101#comment-15743101
]
Jason Lowe commented on HADOOP-13709:
-
Thanks for updating the patch! The unit test failure appears
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716549#comment-15716549
]
Hadoop QA commented on HADOOP-13709:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715954#comment-15715954
]
Jason Lowe commented on HADOOP-13709:
-
Thanks for updating the patch! Synchronization changes look
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715894#comment-15715894
]
Hadoop QA commented on HADOOP-13709:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715670#comment-15715670
]
Jason Lowe commented on HADOOP-13709:
-
The synchronized blocks are unnecessary on the get and put
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713498#comment-15713498
]
Hadoop QA commented on HADOOP-13709:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713310#comment-15713310
]
Jason Lowe commented on HADOOP-13709:
-
The synchronized map needs to be locked explicitly when
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709888#comment-15709888
]
Daryn Sharp commented on HADOOP-13709:
--
+1 assuming no objections from [~jlowe].
> Clean up
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709855#comment-15709855
]
Hadoop QA commented on HADOOP-13709:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709554#comment-15709554
]
Hadoop QA commented on HADOOP-13709:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709098#comment-15709098
]
Daryn Sharp commented on HADOOP-13709:
--
Please declare the map with types so you don't have to
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655202#comment-15655202
]
Eric Badger commented on HADOOP-13709:
--
[~jlowe], [~andrew.wang], [~daryn], do you mind reviewing
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613686#comment-15613686
]
Hadoop QA commented on HADOOP-13709:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595499#comment-15595499
]
Hadoop QA commented on HADOOP-13709:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591860#comment-15591860
]
Daryn Sharp commented on HADOOP-13709:
--
This approach will cause a memory leak and eventually lead
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15582329#comment-15582329
]
Eric Badger commented on HADOOP-13709:
--
The TestZKFailoverController failure is a transient. I
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576733#comment-15576733
]
Hadoop QA commented on HADOOP-13709:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573445#comment-15573445
]
Eric Badger commented on HADOOP-13709:
--
Thanks, [~jlowe], [~daryn]. I will work on a patch that
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573435#comment-15573435
]
Jason Lowe commented on HADOOP-13709:
-
Good catch, Daryn! I missed the memory-model races
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573286#comment-15573286
]
Eric Badger commented on HADOOP-13709:
--
[~daryn], good catch! I was able to recreate the hung test
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573049#comment-15573049
]
Daryn Sharp commented on HADOOP-13709:
--
If you catch it in the act, I bet its going to be some kind
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569128#comment-15569128
]
Eric Badger commented on HADOOP-13709:
--
The TestShell#testShellCommandTimerLeak failure in the
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566829#comment-15566829
]
Eric Badger commented on HADOOP-13709:
--
bq. TestShell fails because it does not have the YARN
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566713#comment-15566713
]
Andrew Wang commented on HADOOP-13709:
--
Hi Eric, do you mind setting affects and target versions
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566438#comment-15566438
]
Eric Badger commented on HADOOP-13709:
--
TestShell fails because it does not have the YARN component
[
https://issues.apache.org/jira/browse/HADOOP-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566348#comment-15566348
]
Hadoop QA commented on HADOOP-13709:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
29 matches
Mail list logo