[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696343#comment-15696343
]
Hudson commented on HADOOP-1381:
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10894 (See
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696299#comment-15696299
]
ASF GitHub Bot commented on HADOOP-1381:
Github user QwertyManiac closed the pull request at:
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15696300#comment-15696300
]
ASF GitHub Bot commented on HADOOP-1381:
Github user QwertyManiac commented on the issue:
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695382#comment-15695382
]
Akira Ajisaka commented on HADOOP-1381:
---
LGTM, +1 for trunk.
> The distance between sync blocks in
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694979#comment-15694979
]
Harsh J commented on HADOOP-1381:
-
[~ajisakaa] / [~ozawa]] - Could you help take a look at this one?
>
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669509#comment-15669509
]
Harsh J commented on HADOOP-1381:
-
Fixed all javac and checkstyle issues except this one:
{code}
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610899#comment-15610899
]
Hadoop QA commented on HADOOP-1381:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608637#comment-15608637
]
ASF GitHub Bot commented on HADOOP-1381:
GitHub user QwertyManiac opened a pull request:
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1340#comment-1340
]
Harsh J commented on HADOOP-1381:
-
Owen/Todd/Others,
Since I've addressed the comments
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284364#comment-13284364
]
Radim Kolar commented on HADOOP-1381:
-
default 1 meg interval should be fine
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284290#comment-13284290
]
Harsh J commented on HADOOP-1381:
-
I do think this would be useful to be able to control,
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273911#comment-13273911
]
Harsh J commented on HADOOP-1381:
-
Any further comments on the addition?
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269152#comment-13269152
]
Hadoop QA commented on HADOOP-1381:
---
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269383#comment-13269383
]
Harsh J commented on HADOOP-1381:
-
bq. -1 javadoc. The javadoc tool appears to have
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237257#comment-13237257
]
Hadoop QA commented on HADOOP-1381:
---
+1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188908#comment-13188908
]
Harsh J commented on HADOOP-1381:
-
Todd/others, are there any other comments you'd like
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156660#comment-13156660
]
Harsh J commented on HADOOP-1381:
-
Todd,
- The sync _interval_ can be arbitrary I think,
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156857#comment-13156857
]
Todd Lipcon commented on HADOOP-1381:
-
hm, if you set it to 0, it will write a sync
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156954#comment-13156954
]
Harsh J commented on HADOOP-1381:
-
Yes, it would end up writing a marker after each
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13101565#comment-13101565
]
Todd Lipcon commented on HADOOP-1381:
-
Two minor nits:
- Can you add a check in the
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13096615#comment-13096615
]
Hadoop QA commented on HADOOP-1381:
---
+1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13082160#comment-13082160
]
Owen O'Malley commented on HADOOP-1381:
---
I agree with Todd's points.
100mb is too
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070773#comment-13070773
]
Todd Lipcon commented on HADOOP-1381:
-
- why use a boxed Integer for the sync
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066556#comment-13066556
]
Harsh J commented on HADOOP-1381:
-
(Avro datafiles have the ability of interval
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066560#comment-13066560
]
Hadoop QA commented on HADOOP-1381:
---
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HADOOP-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066576#comment-13066576
]
Hadoop QA commented on HADOOP-1381:
---
+1 overall. Here are the results of testing the
26 matches
Mail list logo