[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875213#comment-15875213
]
Hadoop QA commented on HADOOP-14041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875009#comment-15875009
]
Hadoop QA commented on HADOOP-14041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874960#comment-15874960
]
Sean Mackrory commented on HADOOP-14041:
Looks good - +1
> CLI command to prune old metadata
>
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874906#comment-15874906
]
Aaron Fabbri commented on HADOOP-14041:
---
Thanks for the folow-up patch [~mackrorysd]. This is
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874513#comment-15874513
]
Steve Loughran commented on HADOOP-14041:
-
Current convention w.r.t interrupts tends to be one
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873462#comment-15873462
]
Hadoop QA commented on HADOOP-14041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873358#comment-15873358
]
Sean Mackrory commented on HADOOP-14041:
{quote}This part of the change could be left out, I
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872846#comment-15872846
]
Aaron Fabbri commented on HADOOP-14041:
---
Thanks for the follow-up patch [~mackrorysd]. Looks
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872436#comment-15872436
]
Hadoop QA commented on HADOOP-14041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871899#comment-15871899
]
Steve Loughran commented on HADOOP-14041:
-
why in {{DynamoDBMetadataStore}} line 584 IOE
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870930#comment-15870930
]
Aaron Fabbri commented on HADOOP-14041:
---
This usage also doesn't work:
{noformat}
$ hadoop s3a
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870761#comment-15870761
]
Aaron Fabbri commented on HADOOP-14041:
---
[~mackrorysd] I'm also fine with doing a followup
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870710#comment-15870710
]
Sean Mackrory commented on HADOOP-14041:
Test failure #5 is addressed by HADOOP-14046. The
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870704#comment-15870704
]
Aaron Fabbri commented on HADOOP-14041:
---
Also, shouldn't this work?
{noformat}
$ hadoop s3a
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870696#comment-15870696
]
Aaron Fabbri commented on HADOOP-14041:
---
Just recording results from my test runs last night:
mvn
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868994#comment-15868994
]
Aaron Fabbri commented on HADOOP-14041:
---
Your latest patch looks good to me, +1.
I'm fine with
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868934#comment-15868934
]
Hadoop QA commented on HADOOP-14041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868432#comment-15868432
]
Sean Mackrory commented on HADOOP-14041:
[~fabbri] Oh you know what? That's what I'm talking
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868367#comment-15868367
]
Aaron Fabbri commented on HADOOP-14041:
---
[~mackrorysd] Any idea what is up with the jenkins unit
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866676#comment-15866676
]
Hadoop QA commented on HADOOP-14041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866447#comment-15866447
]
Sean Mackrory commented on HADOOP-14041:
I missed the javadoc issue locally. The hadoop-common
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866357#comment-15866357
]
Hadoop QA commented on HADOOP-14041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858874#comment-15858874
]
Aaron Fabbri commented on HADOOP-14041:
---
Thank you for the patch. Overall it looks pretty good.
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854863#comment-15854863
]
Aaron Fabbri commented on HADOOP-14041:
---
A couple of thoughts on this patch:
1. I think prune()
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852389#comment-15852389
]
Aaron Fabbri commented on HADOOP-14041:
---
Thanks for the hard work on this [~mackrorysd]. Will try
[
https://issues.apache.org/jira/browse/HADOOP-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850820#comment-15850820
]
Sean Mackrory commented on HADOOP-14041:
Been thinking about it some more and cleaning up
26 matches
Mail list logo
