[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335219#comment-16335219
]
Hanisha Koneru commented on HADOOP-15121:
-
Committed to {{trunk}} and {{branch-3.0}}.
Thanks
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335193#comment-16335193
]
Hudson commented on HADOOP-15121:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13536 (See
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334750#comment-16334750
]
Hanisha Koneru commented on HADOOP-15121:
-
+1 for patch v08.
The failed test cases are unrelated
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334012#comment-16334012
]
genericqa commented on HADOOP-15121:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333929#comment-16333929
]
Tao Jie commented on HADOOP-15121:
--
Thank you [~hanishakoneru]. All testcase is OK now.
> Encounter
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333014#comment-16333014
]
Hanisha Koneru commented on HADOOP-15121:
-
We can check that the {{metricsProxy#delegate}}
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331801#comment-16331801
]
genericqa commented on HADOOP-15121:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331733#comment-16331733
]
Tao Jie commented on HADOOP-15121:
--
[~hanishakoneru], I tried to remove the redundant {{setDelegate}},
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331684#comment-16331684
]
genericqa commented on HADOOP-15121:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331590#comment-16331590
]
Tao Jie commented on HADOOP-15121:
--
[~hanishakoneru] Thank you for you comments.
I improved this patch
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331381#comment-16331381
]
Arpit Agarwal commented on HADOOP-15121:
Done.
> Encounter NullPointerException when using
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331377#comment-16331377
]
Hanisha Koneru commented on HADOOP-15121:
-
[~arpitagarwal], can you please add [~Tao Jie] to the
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331362#comment-16331362
]
Hanisha Koneru commented on HADOOP-15121:
-
Thanks for the patch, [~Tao Jie].
I have a couple
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324964#comment-16324964
]
genericqa commented on HADOOP-15121:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324937#comment-16324937
]
Tao Jie commented on HADOOP-15121:
--
Updated the patch which fixed the checkstyle.
> Encounter
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322544#comment-16322544
]
Ajay Kumar commented on HADOOP-15121:
-
LGTM. There is one minor checkstyle issue for line 684 in
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309695#comment-16309695
]
genericqa commented on HADOOP-15121:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309570#comment-16309570
]
Tao Jie commented on HADOOP-15121:
--
[~ajayydv] thank you for your comment. I updated patch according to
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308633#comment-16308633
]
Ajay Kumar commented on HADOOP-15121:
-
[~Tao Jie] thanks for updating the patch. While testing the
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301035#comment-16301035
]
Tao Jie commented on HADOOP-15121:
--
[~ajayydv] [~brahmareddy] [~anu] would you mind giving the latest
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296104#comment-16296104
]
genericqa commented on HADOOP-15121:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296004#comment-16296004
]
Tao Jie commented on HADOOP-15121:
--
[~ajayydv], thank you for your careful review. I add a catch block
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295376#comment-16295376
]
Ajay Kumar commented on HADOOP-15121:
-
[~Tao Jie], Thanks for adding the test case. We can move
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295180#comment-16295180
]
genericqa commented on HADOOP-15121:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295076#comment-16295076
]
Tao Jie commented on HADOOP-15121:
--
[~ajayydv] thank you for your comments. I added a test about the
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293379#comment-16293379
]
Ajay Kumar commented on HADOOP-15121:
-
[~Tao Jie], Thanks for working on this. Overall patch looks
[
https://issues.apache.org/jira/browse/HADOOP-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292183#comment-16292183
]
Tao Jie commented on HADOOP-15121:
--
I attached a patch that initiate {{delegate}} field in the
27 matches
Mail list logo
