[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-12 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790651#comment-16790651 ] Gabor Bota commented on HADOOP-15625: - My review on patch v15: h3. S3AInputStream.java * Line 193

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-12 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790616#comment-16790616 ] Ben Roling commented on HADOOP-15625: - Thanks [~gabor.bota].  Did you get a chance to review?  

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-11 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789701#comment-16789701 ] Gabor Bota commented on HADOOP-15625: - Test failures seem unrelated. I'll do another review on this

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-11 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789679#comment-16789679 ] Ben Roling commented on HADOOP-15625: - [~ste...@apache.org], [~gabor.bota] - any thoughts on the

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788097#comment-16788097 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-08 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787975#comment-16787975 ] Gabor Bota commented on HADOOP-15625: - Switching to in progress -> patch submitted doesn't help, so

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-08 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787986#comment-16787986 ] Ben Roling commented on HADOOP-15625: - Thanks [~gabor.bota].  I was about to try that myself. >

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-07 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786878#comment-16786878 ] Ben Roling commented on HADOOP-15625: - [~ste...@apache.org] it looks like the build failure issue

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786096#comment-16786096 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-06 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785888#comment-16785888 ] Ben Roling commented on HADOOP-15625: - {quote} java.lang.AssertionError:

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-06 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785822#comment-16785822 ] Gabor Bota commented on HADOOP-15625: - Running the itests with {{mvn clean verify -Dparallel-tests

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785604#comment-16785604 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-05 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785220#comment-16785220 ] Ben Roling commented on HADOOP-15625: - Thanks for the review Steve! Your amendments make sense to

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785167#comment-16785167 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-05 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785040#comment-16785040 ] Steve Loughran commented on HADOOP-15625: - patch 013: tested S3 london, against a versioned

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-05 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785037#comment-16785037 ] Steve Loughran commented on HADOOP-15625: - I patch 012, I Think we're pretty much done. Here

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785035#comment-16785035 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-04 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783884#comment-16783884 ] Steve Loughran commented on HADOOP-15625: - * s3a doesn't work with snowball at all, I do know

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-01 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781915#comment-16781915 ] Ben Roling commented on HADOOP-15625: - On another tangent, something I noticed is that it doesn't

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-01 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781824#comment-16781824 ] Ben Roling commented on HADOOP-15625: - bq. BTW, looking @ amazon snowball docs. They only serve up

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-03-01 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781587#comment-16781587 ] Steve Loughran commented on HADOOP-15625: - BTW, looking @ amazon snowball docs. They only serve

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779970#comment-16779970 ] Hadoop QA commented on HADOOP-15625: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779863#comment-16779863 ] Ben Roling commented on HADOOP-15625: - Patch 012 fixes failure in

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779838#comment-16779838 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779813#comment-16779813 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779773#comment-16779773 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779750#comment-16779750 ] Ben Roling commented on HADOOP-15625: - 011 patch addresses "The patch has 13 line(s) that end in

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779741#comment-16779741 ] Ben Roling commented on HADOOP-15625: - bq. sorry, I must have meant core-default.xml in hadoop

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779740#comment-16779740 ] Ben Roling commented on HADOOP-15625: - 010 patch addresses noisy warning logging. Steve - have

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779735#comment-16779735 ] Steve Loughran commented on HADOOP-15625: - thanks, I'll try and have a look tomorrow. bq. I

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779674#comment-16779674 ] Ben Roling commented on HADOOP-15625: - 009 patch uploaded fixes line length, javadoc, and

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779670#comment-16779670 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-27 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779534#comment-16779534 ] Ben Roling commented on HADOOP-15625: - I've uploaded a new patch: * added configs to

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778719#comment-16778719 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-26 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778676#comment-16778676 ] Ben Roling commented on HADOOP-15625: - I got wrapped up in some other things so didn't make quite

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-26 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778565#comment-16778565 ] Ben Roling commented on HADOOP-15625: - [~ste...@apache.org] - something I noticed with your updates

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-26 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778532#comment-16778532 ] Ben Roling commented on HADOOP-15625: - bq. which means that you may open an object and it has a

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-26 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778417#comment-16778417 ] Steve Loughran commented on HADOOP-15625: - I've been staring at things a bit in the AWS docs.

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-26 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778152#comment-16778152 ] Steve Loughran commented on HADOOP-15625: - FWIW, mandatory etag checking makes sense to me.

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-26 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778019#comment-16778019 ] Ben Roling commented on HADOOP-15625: - Thanks for your help and improvements on this Steve! I'll

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777468#comment-16777468 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777445#comment-16777445 ] Steve Loughran commented on HADOOP-15625: - Ben: I've done an interation on this; handing back

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777319#comment-16777319 ] Hadoop QA commented on HADOOP-15625: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-25 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777268#comment-16777268 ] Ben Roling commented on HADOOP-15625: - New patch uploaded to make a minor variable name tweak in

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775695#comment-16775695 ] Hadoop QA commented on HADOOP-15625: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775689#comment-16775689 ] Hadoop QA commented on HADOOP-15625: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-22 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775662#comment-16775662 ] Ben Roling commented on HADOOP-15625: - [~ste...@apache.org] I've uploaded a new patch. The patch

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-22 Thread Sean Mackrory (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775467#comment-16775467 ] Sean Mackrory commented on HADOOP-15625: Just as a heads up for anyone else following along,

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-22 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775311#comment-16775311 ] Ben Roling commented on HADOOP-15625: - Sorry, [~noslowerdna] clarified for me that PathIOException

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-22 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775306#comment-16775306 ] Ben Roling commented on HADOOP-15625: - bq. How about you make the exception a PathIOException? That

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-22 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775269#comment-16775269 ] Steve Loughran commented on HADOOP-15625: - How about you make the exception a PathIOException?

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-20 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773081#comment-16773081 ] Ben Roling commented on HADOOP-15625: - Thanks Steve. I'll implement the configuration and testing

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-20 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772965#comment-16772965 ] Steve Loughran commented on HADOOP-15625: - third party stores are always somewhat trouble: if

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-19 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771969#comment-16771969 ] Ben Roling commented on HADOOP-15625: - bq. although I wouldn't expect it to be seen so often as to

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-18 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771359#comment-16771359 ] Ben Roling commented on HADOOP-15625: - Thanks [~ste...@apache.org].  I'm not taking it personally. 

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-18 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771191#comment-16771191 ] Steve Loughran commented on HADOOP-15625: - thanks, ben, not had a chance to. running

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-15 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769624#comment-16769624 ] Ben Roling commented on HADOOP-15625: - Hey [~ste...@apache.org] - just wanted to check to see if

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-13 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767530#comment-16767530 ] Ben Roling commented on HADOOP-15625: - {quote}I'd like to have this fail with some special subclass

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-13 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767309#comment-16767309 ] Ben Roling commented on HADOOP-15625: - {quote}With the way the code is structured now, it would

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-13 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767306#comment-16767306 ] Ben Roling commented on HADOOP-15625: - Thanks for the feedback Steve! It does look like I can

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-13 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767032#comment-16767032 ] Steve Loughran commented on HADOOP-15625: - ben: you've to the permissions to attach a patch

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-11 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765486#comment-16765486 ] Ben Roling commented on HADOOP-15625: - Hmm, it seems like I cannot upload a patch to this issue for

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-02-11 Thread Ben Roling (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765485#comment-16765485 ] Ben Roling commented on HADOOP-15625: - I've got a patch that modifies only S3AInputStream and adds

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-01-14 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742458#comment-16742458 ] Steve Loughran commented on HADOOP-15625: - +HADOOP-15751 may be a symptom of the problem. Which

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2019-01-14 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742453#comment-16742453 ] Steve Loughran commented on HADOOP-15625: - Not forgotten thisHADOOP-15229 helps set things

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-12-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721365#comment-16721365 ] Hadoop QA commented on HADOOP-15625: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-12-14 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721297#comment-16721297 ] Steve Loughran commented on HADOOP-15625: - HADOOP-15894 wants those etags too: if an initial

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-12-09 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714130#comment-16714130 ] Steve Loughran commented on HADOOP-15625: - -1 as is Main issues assumes status passed in to

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-11-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703739#comment-16703739 ] Hadoop QA commented on HADOOP-15625: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-11-29 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703695#comment-16703695 ] Steve Loughran commented on HADOOP-15625: - yeah, I know, responsibility is mine. I'll do this.

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-11-29 Thread Brahma Reddy Battula (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703658#comment-16703658 ] Brahma Reddy Battula commented on HADOOP-15625: --- [~ste...@apache.org] My aws account got

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-09-13 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613577#comment-16613577 ] Steve Loughran commented on HADOOP-15625: - Move to a 3.3 feature. I do want this, I'll work

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-09-10 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608993#comment-16608993 ] Steve Loughran commented on HADOOP-15625: - even there, we need to handle risk that third party

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-08-21 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587750#comment-16587750 ] Steve Loughran commented on HADOOP-15625: - Patch is better, but I think we still need to handle

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-08-21 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587724#comment-16587724 ] Steve Loughran commented on HADOOP-15625: - That's not good, and yes, S3Guard: Make sure you

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-08-21 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587482#comment-16587482 ] genericqa commented on HADOOP-15625: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-08-21 Thread Brahma Reddy Battula (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587473#comment-16587473 ] Brahma Reddy Battula commented on HADOOP-15625: --- bq.there's some SSE-C tests which fail

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-08-03 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568773#comment-16568773 ] Steve Loughran commented on HADOOP-15625: - bq. some encryption related tests failed with and

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-08-03 Thread Brahma Reddy Battula (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568169#comment-16568169 ] Brahma Reddy Battula commented on HADOOP-15625: --- Sorry,I missed that it

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-08-01 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566024#comment-16566024 ] Steve Loughran commented on HADOOP-15625: - -1 you have getObjectMetadata() in open(), so added

[jira] [Commented] (HADOOP-15625) S3A input stream to use etags to detect changed source files

2018-07-31 Thread Brahma Reddy Battula (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564334#comment-16564334 ] Brahma Reddy Battula commented on HADOOP-15625: --- Uploaded the initial patch.