[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894101#comment-16894101
]
Hudson commented on HADOOP-16245:
-
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16993 (See
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894055#comment-16894055
]
Erik Krogen commented on HADOOP-16245:
--
Thanks [~vagarychen]! just committed this to trunk,
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894024#comment-16894024
]
Chen Liang commented on HADOOP-16245:
-
Sorry for the delay, v004 patch LGTM, +1.
> Enabling SSL
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892093#comment-16892093
]
Hadoop QA commented on HADOOP-16245:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891927#comment-16891927
]
Erik Krogen commented on HADOOP-16245:
--
Attached v004 patch to address checkstyle/whitespace
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891541#comment-16891541
]
Hadoop QA commented on HADOOP-16245:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891402#comment-16891402
]
Erik Krogen commented on HADOOP-16245:
--
Thanks [~jojochuang], I agree with your assessment.
Spent
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890555#comment-16890555
]
Wei-Chiu Chuang commented on HADOOP-16245:
--
After this patch, a user won't be able to
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890531#comment-16890531
]
Hadoop QA commented on HADOOP-16245:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890476#comment-16890476
]
Chen Liang commented on HADOOP-16245:
-
Thanks Erik, +1 to v002 patch.
> Enabling SSL within
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890471#comment-16890471
]
Erik Krogen commented on HADOOP-16245:
--
Thanks [~vagarychen]! I expanded the description a bit
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890426#comment-16890426
]
Hadoop QA commented on HADOOP-16245:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890353#comment-16890353
]
Chen Liang commented on HADOOP-16245:
-
Thanks for fixing this. v001 patch LGTM.
Just one nit: For
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890292#comment-16890292
]
Erik Krogen commented on HADOOP-16245:
--
I've now tested this on one of our live clusters and
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819245#comment-16819245
]
Erik Krogen commented on HADOOP-16245:
--
I agree that storing the values in a static class is not
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819236#comment-16819236
]
Daryn Sharp commented on HADOOP-16245:
--
Storing the SSL parameters as statics in a static class is
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819212#comment-16819212
]
Wei-Chiu Chuang commented on HADOOP-16245:
--
Yeah you're right about that. Also currently I
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819183#comment-16819183
]
Erik Krogen commented on HADOOP-16245:
--
I thought about how to leverage the code in {{SSLFactory}}
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819032#comment-16819032
]
Wei-Chiu Chuang commented on HADOOP-16245:
--
Hi [~xkrogen] thanks for reporting the issue.
I
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816654#comment-16816654
]
Hadoop QA commented on HADOOP-16245:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816588#comment-16816588
]
Erik Krogen commented on HADOOP-16245:
--
Attaching a v000 patch for initial review while we start
21 matches
Mail list logo