[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904791#comment-16904791 ] Lisheng Sun commented on HADOOP-16453: -- [~elgoiri] Should we commit this patch to trunk? Thank

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903142#comment-16903142 ] Íñigo Goiri commented on HADOOP-16453: -- Thanks [~leosun08]. +1 from my side. Anybody else wants to

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902594#comment-16902594 ] Lisheng Sun commented on HADOOP-16453: -- hi [~elgoiri] I run all UT in HDFS and YARN of my local

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901293#comment-16901293 ] Íñigo Goiri commented on HADOOP-16453: -- As this is the core for many other components, can you run

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900752#comment-16900752 ] Hadoop QA commented on HADOOP-16453: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900681#comment-16900681 ] Lisheng Sun commented on HADOOP-16453: -- Fix UT in hadoop.ipc.TestIPC and upload the v5 patch. 

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900660#comment-16900660 ] Hadoop QA commented on HADOOP-16453: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900592#comment-16900592 ] Lisheng Sun commented on HADOOP-16453: -- Fix checkstyle issue and upload the v4 patch. > Update

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900590#comment-16900590 ] Hadoop QA commented on HADOOP-16453: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900542#comment-16900542 ] Lisheng Sun commented on HADOOP-16453: -- Thanx [~elgoiri] for your suggestions. I updated comments

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900279#comment-16900279 ] Íñigo Goiri commented on HADOOP-16453: -- As the unit test shows, we are changing the behavior a

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899570#comment-16899570 ] He Xiaoqiao commented on HADOOP-16453: -- +1 for [^HADOOP-16453.002.patch] from my side. Thanks

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899567#comment-16899567 ] Lisheng Sun commented on HADOOP-16453: -- hi [~elgoiri]  Could you mind continue to review this

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898215#comment-16898215 ] Íñigo Goiri commented on HADOOP-16453: -- {quote} Íñigo Goiri Do you intent to mean that we remove

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898139#comment-16898139 ] Hadoop QA commented on HADOOP-16453: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898088#comment-16898088 ] Ayush Saxena commented on HADOOP-16453: --- [~leosun08] We can't return exception just as it is,

[jira] [Commented] (HADOOP-16453) Update how exceptions are handled in NetUtils.java

[ https://issues.apache.org/jira/browse/HADOOP-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898085#comment-16898085 ] Lisheng Sun commented on HADOOP-16453: -- Thanx [~elgoiri] for your suggestion. I have updated this