[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2012-01-03 Thread hanasaki jiji (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179087#comment-13179087 ] hanasaki jiji commented on HADOOP-6605: --- installed hadoop 1.0.0 .deb package on deb

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049471#comment-13049471 ] Hudson commented on HADOOP-6605: Integrated in Hadoop-Common-trunk-maven #17 (See [https

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048860#comment-13048860 ] Hudson commented on HADOOP-6605: Integrated in Hadoop-Common-trunk-Commit #652 (See [htt

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-13 Thread Eli Collins (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048843#comment-13048843 ] Eli Collins commented on HADOOP-6605: - Thanks. I left the if as single bracket to be

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-13 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048839#comment-13048839 ] Daryn Sharp commented on HADOOP-6605: - +1 I'd recommend double square brackets again

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-13 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048707#comment-13048707 ] Daryn Sharp commented on HADOOP-6605: - Great, thanks Allen! From everything I've rea

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-13 Thread Chris Douglas (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048695#comment-13048695 ] Chris Douglas commented on HADOOP-6605: --- +1 on the OS X detection > Add JAVA_HOME

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-13 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048672#comment-13048672 ] Allen Wittenauer commented on HADOOP-6605: -- I'll change my vote to 0 for this pa

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-13 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048651#comment-13048651 ] Daryn Sharp commented on HADOOP-6605: - I'd like to succinctly reassert that it's unex

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-13 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048612#comment-13048612 ] Allen Wittenauer commented on HADOOP-6605: -- I still think this is a bad idea, ev

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-13 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048566#comment-13048566 ] Daryn Sharp commented on HADOOP-6605: - +1 Beautiful! My only suggestion would be to

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-06-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048252#comment-13048252 ] Hadoop QA commented on HADOOP-6605: --- -1 overall. Here are the results of testing the l

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-21 Thread Bharath Mundlapudi (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037435#comment-13037435 ] Bharath Mundlapudi commented on HADOOP-6605: Most of the time, i do side-by-s

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-20 Thread Chris Douglas (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037110#comment-13037110 ] Chris Douglas commented on HADOOP-6605: --- This struck me as an obvious win, but I'm

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-20 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036951#comment-13036951 ] Allen Wittenauer commented on HADOOP-6605: -- My technical objection is that there

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036849#comment-13036849 ] Daryn Sharp commented on HADOOP-6605: - (btw, I previously attempted to imply my neg w

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-19 Thread Eli Collins (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036559#comment-13036559 ] Eli Collins commented on HADOOP-6605: - Thanks for reviewing Daryn! bq. SunOS - why

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-19 Thread Eli Collins (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036511#comment-13036511 ] Eli Collins commented on HADOOP-6605: - In the above the ". bin/hadoop-config.sh" shou

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-19 Thread Eli Collins (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036480#comment-13036480 ] Eli Collins commented on HADOOP-6605: - bq. FYI: I'm not removing my -1 as long as thi

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-19 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036268#comment-13036268 ] Allen Wittenauer commented on HADOOP-6605: -- FYI: I'm not removing my -1 as long

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-19 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036205#comment-13036205 ] Daryn Sharp commented on HADOOP-6605: - Correction: Eli's concern = Allen's concern.

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-19 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036202#comment-13036202 ] Daryn Sharp commented on HADOOP-6605: - Love it. Comments: SunOS - why not jdk1.6.*

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035686#comment-13035686 ] Allen Wittenauer commented on HADOOP-6605: -- I'm sure that would remain true if A

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035679#comment-13035679 ] Daryn Sharp commented on HADOOP-6605: - bq. java_home is not a stable interface. It ca

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035669#comment-13035669 ] Daryn Sharp commented on HADOOP-6605: - (My apologies on the neg. I thought no number

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Eli Collins (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035659#comment-13035659 ] Eli Collins commented on HADOOP-6605: - bq. a) we're getting into platform specific co

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035654#comment-13035654 ] Allen Wittenauer commented on HADOOP-6605: -- java_home is not a stable interface.

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Eli Collins (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035619#comment-13035619 ] Eli Collins commented on HADOOP-6605: - Thanks for the feedback Daryn. It looks like

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035609#comment-13035609 ] Daryn Sharp commented on HADOOP-6605: - -1: Only in that I don't like the logic as it

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Eli Collins (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035606#comment-13035606 ] Eli Collins commented on HADOOP-6605: - bq. Why this shouldn't be in a one-time setup

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035578#comment-13035578 ] Allen Wittenauer commented on HADOOP-6605: -- Why this shouldn't be in a one-time

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Eli Collins (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035537#comment-13035537 ] Eli Collins commented on HADOOP-6605: - Allen raised some good questions earlier... b

[jira] [Commented] (HADOOP-6605) Add JAVA_HOME detection to hadoop-config

2011-05-18 Thread Eli Collins (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035524#comment-13035524 ] Eli Collins commented on HADOOP-6605: - Forgot to mention testing, since the unit test