[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2013-03-29 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617747#comment-13617747 ] Sanjay Radia commented on HADOOP-8990: -- The general practice in protobuf is to make

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2013-01-31 Thread Binglin Chang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567729#comment-13567729 ] Binglin Chang commented on HADOOP-8990: --- To archive this one potential issue is how

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2013-01-30 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567132#comment-13567132 ] Sanjay Radia commented on HADOOP-8990: -- bq. so you plan to serialize header and body

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2013-01-21 Thread Binglin Chang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559402#comment-13559402 ] Binglin Chang commented on HADOOP-8990: --- Sorry, I made a mistake, looks like curren

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2013-01-21 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559270#comment-13559270 ] Sanjay Radia commented on HADOOP-8990: -- Won't the first 4byte length size (ie total

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2013-01-21 Thread Binglin Chang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559262#comment-13559262 ] Binglin Chang commented on HADOOP-8990: --- bq. Note that since rpc has pluggable rpc

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2013-01-21 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559006#comment-13559006 ] Sanjay Radia commented on HADOOP-8990: -- bq. The final wire format would be(I assume

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2013-01-15 Thread Binglin Chang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554818#comment-13554818 ] Binglin Chang commented on HADOOP-8990: --- Thanks for all this, Sanjay. Let me summar

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2013-01-15 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554774#comment-13554774 ] Sanjay Radia commented on HADOOP-8990: -- I have filed jiras for addressing all feedba

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2013-01-15 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554576#comment-13554576 ] Sanjay Radia commented on HADOOP-8990: -- bq. there are still some Writables: RpcReque

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2012-12-17 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534489#comment-13534489 ] Sanjay Radia commented on HADOOP-8990: -- bq. 3. The rpc system is not fully protobuf

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2012-12-13 Thread Binglin Chang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532068#comment-13532068 ] Binglin Chang commented on HADOOP-8990: --- bq. Note hadoop-rpc.proto is for the proto

[jira] [Commented] (HADOOP-8990) Some minor issus in protobuf based ipc

2012-12-13 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531600#comment-13531600 ] Sanjay Radia commented on HADOOP-8990: -- bq. 1. proto file naming bq. 2. proto class