[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647786#comment-13647786
]
Arpit Agarwal commented on HADOOP-9043:
---
Thanks for addressing that.
+1
Verified
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647918#comment-13647918
]
Suresh Srinivas commented on HADOOP-9043:
-
+1 for the patch.
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642207#comment-13642207
]
Chris Nauroth commented on HADOOP-9043:
---
To the committer who picks this up: would
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634891#comment-13634891
]
Hadoop QA commented on HADOOP-9043:
---
{color:green}+1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634939#comment-13634939
]
Ivan Mitic commented on HADOOP-9043:
Looks good, +1 on both trunk and branch-1-win
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634249#comment-13634249
]
Chris Nauroth commented on HADOOP-9043:
---
{quote}
Should we open a new JIRA to
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634257#comment-13634257
]
Ivan Mitic commented on HADOOP-9043:
Thanks Chris for addressing the comments.
bq.
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634601#comment-13634601
]
Hadoop QA commented on HADOOP-9043:
---
{color:green}+1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634803#comment-13634803
]
Ivan Mitic commented on HADOOP-9043:
Thanks Chris, patch looks really good! One minor
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632419#comment-13632419
]
Chuan Liu commented on HADOOP-9043:
---
I am +1 on the existing patches to fix the
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631413#comment-13631413
]
Ivan Mitic commented on HADOOP-9043:
Thanks Chris for the patch! I am reviewing this
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631428#comment-13631428
]
Ivan Mitic commented on HADOOP-9043:
Thanks Chris for the writeup on readLink! The
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630513#comment-13630513
]
Chris Nauroth commented on HADOOP-9043:
---
I was just trying to resume progress on
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605438#comment-13605438
]
Chuan Liu commented on HADOOP-9043:
---
+1 on the symlink path, and agree with Chris to
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605439#comment-13605439
]
Chuan Liu commented on HADOOP-9043:
---
Sorry for the typo: symlink -path- should be
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599006#comment-13599006
]
Chris Nauroth commented on HADOOP-9043:
---
Tightening up the validation is great, but
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595319#comment-13595319
]
Hadoop QA commented on HADOOP-9043:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595338#comment-13595338
]
Ivan Mitic commented on HADOOP-9043:
Thanks Arpit, this is good. A few comments,
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595345#comment-13595345
]
Arpit Agarwal commented on HADOOP-9043:
---
Forward paths in the source already appear
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595350#comment-13595350
]
Ivan Mitic commented on HADOOP-9043:
bq. Forward paths in the source already appear
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584877#comment-13584877
]
Chuan Liu commented on HADOOP-9043:
---
To summary the cause of the problem:
Windows
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583336#comment-13583336
]
Chris Nauroth commented on HADOOP-9043:
---
{quote}
To fix this specific problem, we
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583384#comment-13583384
]
Arpit Agarwal commented on HADOOP-9043:
---
Hi Ivan, Chris,
I think the behavior of
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583766#comment-13583766
]
Ivan Mitic commented on HADOOP-9043:
Thanks Arpit. I am fine with failing early in
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582746#comment-13582746
]
Ivan Mitic commented on HADOOP-9043:
Thanks Arpit!
I just looked at the patch, and I
[
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497813#comment-13497813
]
Chris Nauroth commented on HADOOP-9043:
---
This is best illustrated through an
26 matches
Mail list logo
