[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690066#comment-13690066 ] Daryn Sharp commented on HADOOP-9421: - bq. If we have to replace Digest-MD5 for

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690136#comment-13690136 ] Luke Lu commented on HADOOP-9421: - bq. There is nothing in the protocol that would

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690241#comment-13690241 ] Daryn Sharp commented on HADOOP-9421: - bq. I meant you'll be SOL to make the token

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690351#comment-13690351 ] Daryn Sharp commented on HADOOP-9421: - Although I don't see a scenario in which this

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690496#comment-13690496 ] Luke Lu commented on HADOOP-9421: - bq. Ok, so now how would you handle improved serverId

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690510#comment-13690510 ] Luke Lu commented on HADOOP-9421: - bq. I'll just add it. Thank you! It's important to

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690513#comment-13690513 ] Daryn Sharp commented on HADOOP-9421: - It's really not worth debating anymore, but if

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690539#comment-13690539 ] Luke Lu commented on HADOOP-9421: - bq. if the client decided to guess and blast a

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690558#comment-13690558 ] Luke Lu commented on HADOOP-9421: - bq. Server will not SASL respond to a client until it

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690585#comment-13690585 ] Luke Lu commented on HADOOP-9421: - I'm fine with the new protocol. I agree that

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690593#comment-13690593 ] Hadoop QA commented on HADOOP-9421: --- {color:green}+1 overall{color}. Here are the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690600#comment-13690600 ] Luke Lu commented on HADOOP-9421: - In light of the bug, can you add a unit test for the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690604#comment-13690604 ] Daryn Sharp commented on HADOOP-9421: - That's not a bug. The logic is if the client

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690626#comment-13690626 ] Luke Lu commented on HADOOP-9421: - You're right, I somehow read that it is trying to

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690638#comment-13690638 ] Daryn Sharp commented on HADOOP-9421: - We agreed that guessing wasn't going to be

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690639#comment-13690639 ] Daryn Sharp commented on HADOOP-9421: - Oh, and I did manually test on a secure

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-21 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690650#comment-13690650 ] Luke Lu commented on HADOOP-9421: - Filed HADOOP-9662 for more unit tests. +1 for the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688991#comment-13688991 ] Luke Lu commented on HADOOP-9421: - bq. As described, optimize token path. [Your

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689025#comment-13689025 ] Hadoop QA commented on HADOOP-9421: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689130#comment-13689130 ] Hadoop QA commented on HADOOP-9421: --- {color:green}+1 overall{color}. Here are the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689208#comment-13689208 ] Daryn Sharp commented on HADOOP-9421: - bq. Only works with token auths that use

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689283#comment-13689283 ] Daryn Sharp commented on HADOOP-9421: - I don't understand the advantage of this

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689336#comment-13689336 ] Luke Lu commented on HADOOP-9421: - bq. I don't understand the advantage of this patch. At

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689451#comment-13689451 ] Luke Lu commented on HADOOP-9421: - Specifically: bq. Re-introduces the roundtrip I

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689490#comment-13689490 ] Daryn Sharp commented on HADOOP-9421: - I'm referring to the roundtrip your patch

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689619#comment-13689619 ] Luke Lu commented on HADOOP-9421: - bq. I'm referring to the roundtrip your patch

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689739#comment-13689739 ] Sanjay Radia commented on HADOOP-9421: -- bq. The client can't chose the best auth

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689759#comment-13689759 ] Sanjay Radia commented on HADOOP-9421: -- Luke, Daryn can both of you please summarize

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689763#comment-13689763 ] Daryn Sharp commented on HADOOP-9421: - bq. That is correct. BTW Client can guess the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Larry McCay (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689774#comment-13689774 ] Larry McCay commented on HADOOP-9421: - Just a thought... I have recently found the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689823#comment-13689823 ] Daryn Sharp commented on HADOOP-9421: - +Simple to insecure+ {noformat} C - S

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689870#comment-13689870 ] Luke Lu commented on HADOOP-9421: - My simple to \* is equivalent Daryn's. Note,

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Arun C Murthy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689895#comment-13689895 ] Arun C Murthy commented on HADOOP-9421: --- Guys, how far are we from getting this

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689940#comment-13689940 ] Daryn Sharp commented on HADOOP-9421: - I know Luke means well, but an initial

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689943#comment-13689943 ] Luke Lu commented on HADOOP-9421: - My patch is ready to review, commit and scale testing.

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689950#comment-13689950 ] Daryn Sharp commented on HADOOP-9421: - We also need to consider the issues caused by

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Benoy Antony (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689952#comment-13689952 ] Benoy Antony commented on HADOOP-9421: -- Luke, Is there a sufficient need to add a

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689955#comment-13689955 ] Daryn Sharp commented on HADOOP-9421: - If it's not obvious, I'm -1 on Luke's patch.

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689959#comment-13689959 ] Daryn Sharp commented on HADOOP-9421: - You can do the feature that will never used by

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689961#comment-13689961 ] Luke Lu commented on HADOOP-9421: - bq. Luke, Is there a sufficient need to add a new

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689971#comment-13689971 ] Luke Lu commented on HADOOP-9421: - bq. Luke's patch is 8-11ms slower with Kerberos than

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689976#comment-13689976 ] Daryn Sharp commented on HADOOP-9421: - No, you cannot try to further avoid the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689980#comment-13689980 ] Luke Lu commented on HADOOP-9421: - bq. At best the client will fail to initiate GSSAPI

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690034#comment-13690034 ] Daryn Sharp commented on HADOOP-9421: - You seem to be trying to tailor a design that

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-20 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690051#comment-13690051 ] Luke Lu commented on HADOOP-9421: - bq. In a world of multiple auths and multiple

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687645#comment-13687645 ] Sanjay Radia commented on HADOOP-9421: -- bq. Client today does send/(send/read)+, and

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688005#comment-13688005 ] Daryn Sharp commented on HADOOP-9421: - Maybe I'm misunderstanding, but won't the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688055#comment-13688055 ] Daryn Sharp commented on HADOOP-9421: - I think I may be able to make everyone happy,

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688438#comment-13688438 ] Hadoop QA commented on HADOOP-9421: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688441#comment-13688441 ] Luke Lu commented on HADOOP-9421: - New patch flow: packet 1: C-S connectionHeader +

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688449#comment-13688449 ] Luke Lu commented on HADOOP-9421: - Looks like I need to merge with atm's

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688459#comment-13688459 ] Sanjay Radia commented on HADOOP-9421: -- Daryn, it appears that this proposal is not

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688464#comment-13688464 ] Sanjay Radia commented on HADOOP-9421: -- Daryn, to fully understand you need to

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688470#comment-13688470 ] Luke Lu commented on HADOOP-9421: - bq. it appears that this proposal is not wrapping sasl

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688472#comment-13688472 ] Luke Lu commented on HADOOP-9421: - bq. Simply wrapping sasl in protobuf headers would be

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688514#comment-13688514 ] Sanjay Radia commented on HADOOP-9421: -- bq. packet 2: C-S

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688556#comment-13688556 ] Luke Lu commented on HADOOP-9421: - SASL itself doesn't negotiate. Currently we have hack

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688558#comment-13688558 ] Sanjay Radia commented on HADOOP-9421: -- We do not have a way to test such a major

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688564#comment-13688564 ] Daryn Sharp commented on HADOOP-9421: - SASL just defines the format of the bytes used

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688576#comment-13688576 ] Daryn Sharp commented on HADOOP-9421: - bq. We do not have a way to test such a major

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688579#comment-13688579 ] Luke Lu commented on HADOOP-9421: - bq. We do not have a way to test such a major change

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Arun C Murthy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688622#comment-13688622 ] Arun C Murthy commented on HADOOP-9421: --- How much more work are we talking about

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688657#comment-13688657 ] Luke Lu commented on HADOOP-9421: - I think it's close. It needs to be rebased against

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13688801#comment-13688801 ] Hadoop QA commented on HADOOP-9421: --- {color:green}+1 overall{color}. Here are the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-18 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687233#comment-13687233 ] Daryn Sharp commented on HADOOP-9421: - Per Sanjay's request, here's a quick summary:

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-18 Thread Arun C Murthy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687375#comment-13687375 ] Arun C Murthy commented on HADOOP-9421: --- Is there any reason to not commit this and

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-18 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687643#comment-13687643 ] Sanjay Radia commented on HADOOP-9421: -- bq. Client today does send/(send/read)+, and

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-17 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13685656#comment-13685656 ] Daryn Sharp commented on HADOOP-9421: - Depending on how you define round trip, it's

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-14 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683488#comment-13683488 ] Daryn Sharp commented on HADOOP-9421: - As a followup, I'm trying to get some

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-14 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683896#comment-13683896 ] Daryn Sharp commented on HADOOP-9421: - Given today's network speeds, I'm not going to

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-14 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683963#comment-13683963 ] Luke Lu commented on HADOOP-9421: - bq. Given today's network speeds, I'm not going to

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-13 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13682366#comment-13682366 ] Daryn Sharp commented on HADOOP-9421: - The changes in this jira fundamentally boils

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-12 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13681360#comment-13681360 ] Daryn Sharp commented on HADOOP-9421: - bq. I don't think ID_TOKEN or SSO_TOKEN being

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-12 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13681564#comment-13681564 ] Luke Lu commented on HADOOP-9421: - bq. At the moment, I'm only trying to make the minimal

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-12 Thread Sanjay Radia (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13681607#comment-13681607 ] Sanjay Radia commented on HADOOP-9421: -- bq. I'm only suggest that we simply send a

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-11 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13680770#comment-13680770 ] Daryn Sharp commented on HADOOP-9421: - bq. As long as the mech is TOKEN (or better

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-11 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13680842#comment-13680842 ] Luke Lu commented on HADOOP-9421: - bq. The abstract name appears in the stringified UGI,

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-10 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679663#comment-13679663 ] Daryn Sharp commented on HADOOP-9421: - Shorting out the NEGOTIATE for a re-connect

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-10 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679738#comment-13679738 ] Luke Lu commented on HADOOP-9421: - bq. Shorting out the NEGOTIATE for a re-connect

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-10 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679842#comment-13679842 ] Daryn Sharp commented on HADOOP-9421: - I believe you are proposing the client always

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-10 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679870#comment-13679870 ] Luke Lu commented on HADOOP-9421: - bq. This optimizes a reconnect, but the common case

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-10 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679908#comment-13679908 ] Luke Lu commented on HADOOP-9421: - bq. By saying you can live with it, is that a tacit

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-10 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679966#comment-13679966 ] Daryn Sharp commented on HADOOP-9421: - I'm open to improvements, but I'm having a

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-10 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679985#comment-13679985 ] Luke Lu commented on HADOOP-9421: - bq. The client can't generate an initial SASL response

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-10 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13680067#comment-13680067 ] Luke Lu commented on HADOOP-9421: - Trying to see why you're not seeing what I'm seeing:

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-09 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679107#comment-13679107 ] Luke Lu commented on HADOOP-9421: - bq. As-is, it would be possible for the client to

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-07 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678045#comment-13678045 ] Daryn Sharp commented on HADOOP-9421: - Findbugs is grumping about a switch case not

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-07 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678288#comment-13678288 ] Luke Lu commented on HADOOP-9421: - bq. The IpSerializationType change is orthogonal to

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-07 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678356#comment-13678356 ] Daryn Sharp commented on HADOOP-9421: - bq. The main thing I'd like to have is be able

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678404#comment-13678404 ] Hadoop QA commented on HADOOP-9421: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13677706#comment-13677706 ] Hadoop QA commented on HADOOP-9421: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-06-05 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13675923#comment-13675923 ] Daryn Sharp commented on HADOOP-9421: - Thanks Luke. Removing the AuthMethod proved

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-05-31 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13671898#comment-13671898 ] Luke Lu commented on HADOOP-9421: - Had a good call with Daryn, Thanks! I think I

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-05-29 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669286#comment-13669286 ] Daryn Sharp commented on HADOOP-9421: - bq. The main problem with mixing SASL exchange

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-05-29 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669409#comment-13669409 ] Daryn Sharp commented on HADOOP-9421: - Of note, none of the benefits I mentioned is

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-05-29 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669511#comment-13669511 ] Luke Lu commented on HADOOP-9421: - bq. This is our last shot for a long time to make RPC

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-05-29 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669681#comment-13669681 ] Daryn Sharp commented on HADOOP-9421: - I still think there's confusion here. I'm not

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-05-29 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669723#comment-13669723 ] Luke Lu commented on HADOOP-9421: - bq. I still think there's confusion here. I'm not

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-05-28 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13668308#comment-13668308 ] Daryn Sharp commented on HADOOP-9421: - No updated tests because a) existing tests

[jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing

2013-05-28 Thread Luke Lu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13668707#comment-13668707 ] Luke Lu commented on HADOOP-9421: - The main problem with mixing SASL exchange with RPC

  1   2   >