Xiaoyu Yao created HADOOP-13244:
-----------------------------------

             Summary: o.a.h.ipc.Server#Server should honor handlerCount when 
queueSizePerHandler is specified in consturctor
                 Key: HADOOP-13244
                 URL: https://issues.apache.org/jira/browse/HADOOP-13244
             Project: Hadoop Common
          Issue Type: Bug
          Components: ipc
            Reporter: Xiaoyu Yao
            Priority: Minor


In the code below,  {{this.maxQueueSize = queueSizePerHandler;}} should be 
{{ this.maxQueueSize = handlerCount * queueSizePerHandler;}}. Luckily, I search 
the code base and found most callers invoke the constructor with 
queueSizePerHandler=-1. This ticket is opened to make it correct for the case 
when queueSizePerHandler is not -1. 

{code}
if (queueSizePerHandler != -1) {
      this.maxQueueSize = queueSizePerHandler;
    } else {
      this.maxQueueSize = handlerCount * conf.getInt(
          CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_KEY,
          CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_DEFAULT);      
    }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to