[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-12-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788681#action_12788681 ] Hudson commented on HADOOP-6346: Integrated in Hadoop-Common-trunk #183 (See [http://huds

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-12-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788389#action_12788389 ] Hudson commented on HADOOP-6346: Integrated in Hadoop-Common-trunk-Commit #103 (See [http

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-12-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786122#action_12786122 ] Hadoop QA commented on HADOOP-6346: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-12-04 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786079#action_12786079 ] Tom White commented on HADOOP-6346: --- Looks good. One nit: there's a typo in Configuratio

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-12-01 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784695#action_12784695 ] Todd Lipcon commented on HADOOP-6346: - Sounds great. There are no tests that will curr

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-12-01 Thread Vinod K V (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784686#action_12784686 ] Vinod K V commented on HADOOP-6346: --- bq. Only issue to worry about is that MAPREDUCE-967

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-12-01 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784670#action_12784670 ] Todd Lipcon commented on HADOOP-6346: - bq. Gone through the patch for one final time.

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-12-01 Thread Vinod K V (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784658#action_12784658 ] Vinod K V commented on HADOOP-6346: --- bq. I think we should leave the classpath alone. As

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-12-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784647#action_12784647 ] Hadoop QA commented on HADOOP-6346: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-11-16 Thread Vinod K V (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778734#action_12778734 ] Vinod K V commented on HADOOP-6346: --- bq. Are you suggesting opening up the jar with a ne

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-11-16 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778702#action_12778702 ] Todd Lipcon commented on HADOOP-6346: - bq. Shouldn't we use the same pattern for RunJa

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-11-16 Thread Vinod K V (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778245#action_12778245 ] Vinod K V commented on HADOOP-6346: --- Patch looks mostly good. Two comments: - Shouldn't

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-11-13 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777800#action_12777800 ] Todd Lipcon commented on HADOOP-6346: - One self-review comment: there's an unused UNPA

[jira] Commented: (HADOOP-6346) Add support for specifying unpack pattern regex to RunJar.unJar

2009-11-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1238#action_1238 ] Hadoop QA commented on HADOOP-6346: --- +1 overall. Here are the results of testing the la