[jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum

2010-04-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861271#action_12861271 ] Hadoop QA commented on HADOOP-6677: --- -1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum

2010-04-25 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860796#action_12860796 ] Tom White commented on HADOOP-6677: --- I agree we can discuss a change in semantics elsewh

[jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum

2010-04-25 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860770#action_12860770 ] Jakob Homan commented on HADOOP-6677: - So basically, +1 on this patch. Any changes to

[jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum

2010-04-25 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860769#action_12860769 ] Jakob Homan commented on HADOOP-6677: - I'm OK with the switch to strings; it'll make t

[jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum

2010-04-12 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856234#action_12856234 ] Tom White commented on HADOOP-6677: --- > This would be a pretty big change to the classifi

[jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum

2010-04-06 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854323#action_12854323 ] Jakob Homan commented on HADOOP-6677: - This would be a pretty big change to the classi

[jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum

2010-04-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854322#action_12854322 ] Hadoop QA commented on HADOOP-6677: --- -1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum

2010-04-05 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853507#action_12853507 ] Tom White commented on HADOOP-6677: --- Perhaps it could be optional - if no components are

[jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum

2010-04-05 Thread Alan Gates (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853484#action_12853484 ] Alan Gates commented on HADOOP-6677: The thing I like about having a component name as

[jira] Commented: (HADOOP-6677) InterfaceAudience.LimitedPrivate should take a string not an enum

2010-04-04 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853300#action_12853300 ] Tom White commented on HADOOP-6677: --- +1 However, I wonder if we could go further and not