[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878381#action_12878381 ] Hudson commented on HADOOP-6796: Integrated in Hadoop-Common-trunk #365 (See [http://huds

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878348#action_12878348 ] Hudson commented on HADOOP-6796: Integrated in Hadoop-Common-trunk-Commit #302 (See [http

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878345#action_12878345 ] Eli Collins commented on HADOOP-6796: - Reverted the patch, confirmed TestCopyFiles pas

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878344#action_12878344 ] Rodrigo Schmidt commented on HADOOP-6796: - Sure! Go ahead and revert it please. >

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878343#action_12878343 ] Eli Collins commented on HADOOP-6796: - I'll revert the change. If we want to reintrodu

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878203#action_12878203 ] Rodrigo Schmidt commented on HADOOP-6796: - I think it's just bad initialization. p

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878188#action_12878188 ] Jakob Homan commented on HADOOP-6796: - +1 on revert. Writables are dangerous, we'll j

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877878#action_12877878 ] Tsz Wo (Nicholas), SZE commented on HADOOP-6796: The patch causes TestCopy

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877396#action_12877396 ] Hudson commented on HADOOP-6796: Integrated in Hadoop-Common-trunk #362 (See [http://huds

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877157#action_12877157 ] Hudson commented on HADOOP-6796: Integrated in Hadoop-Common-trunk-Commit #291 (See [http

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877127#action_12877127 ] Eli Collins commented on HADOOP-6796: - +1 I'll commit soon. > FileStatus allows null

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877045#action_12877045 ] Hadoop QA commented on HADOOP-6796: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876587#action_12876587 ] Hadoop QA commented on HADOOP-6796: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875518#action_12875518 ] Eli Collins commented on HADOOP-6796: - I think just checking the path is fine. > File

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875486#action_12875486 ] Rodrigo Schmidt commented on HADOOP-6796: - Do you guys think I should add more che

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875472#action_12875472 ] Jakob Homan commented on HADOOP-6796: - It's fine, I guess. The new patch won't cause

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875284#action_12875284 ] Eli Collins commented on HADOOP-6796: - Looks reasonable to me. What do you think Jako

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875199#action_12875199 ] Eli Collins commented on HADOOP-6796: - If it's never ok to pass null for the path (ie

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875003#action_12875003 ] Rodrigo Schmidt commented on HADOOP-6796: - I just realized the FileStatus construc

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874763#action_12874763 ] Jakob Homan commented on HADOOP-6796: - Rodrigo: any constructor that converts an empty

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874754#action_12874754 ] Rodrigo Schmidt commented on HADOOP-6796: - No problem. I'll submit a new patch soo

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874753#action_12874753 ] Eli Collins commented on HADOOP-6796: - Seems reasonable to me. Thanks for all the bac

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874749#action_12874749 ] Rodrigo Schmidt commented on HADOOP-6796: - Okay! I see your point. Maybe we shoul

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874740#action_12874740 ] Eli Collins commented on HADOOP-6796: - I think classes like FileStatus (eg writables)

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874719#action_12874719 ] Rodrigo Schmidt commented on HADOOP-6796: - I'm not worried about my test. I fixed

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874658#action_12874658 ] Eli Collins commented on HADOOP-6796: - Sounds like the simple thing to do is have your

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874487#action_12874487 ] Rodrigo Schmidt commented on HADOOP-6796: - @Eli: I noticed this problem while writ

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874437#action_12874437 ] Jakob Homan commented on HADOOP-6796: - bq. You could also modify Path to accept Path("

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874396#action_12874396 ] Eli Collins commented on HADOOP-6796: - You could also modify Path to accept Path("") o

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874382#action_12874382 ] Rodrigo Schmidt commented on HADOOP-6796: - Wow! I didn't know this would create so

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874361#action_12874361 ] Eli Collins commented on HADOOP-6796: - If you can get rid of the FileStatus() construc

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874362#action_12874362 ] Jakob Homan commented on HADOOP-6796: - bq. So are you proposing to get rid of the File

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874347#action_12874347 ] Rodrigo Schmidt commented on HADOOP-6796: - So are you proposing to get rid of the

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874338#action_12874338 ] Eli Collins commented on HADOOP-6796: - In cases where you want to explicitly tolerate

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874284#action_12874284 ] Rodrigo Schmidt commented on HADOOP-6796: - What should be the srcPath for "new Fil

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874275#action_12874275 ] Eli Collins commented on HADOOP-6796: - Shouldn't people who want a FileStatus that rep

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874228#action_12874228 ] Rodrigo Schmidt commented on HADOOP-6796: - @Dmytro: srcPath is currently defined a

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874212#action_12874212 ] Eli Collins commented on HADOOP-6796: - Why does anyone create a FileStatus with a null

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874176#action_12874176 ] Scott Chen commented on HADOOP-6796: Rodrigo: Will returning "/" change some of the ex

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874175#action_12874175 ] Dmytro Molkov commented on HADOOP-6796: --- Did you think of using an empty string inst

[jira] Commented: (HADOOP-6796) FileStatus allows null srcPath but crashes if that's done

[ https://issues.apache.org/jira/browse/HADOOP-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874001#action_12874001 ] Hadoop QA commented on HADOOP-6796: --- +1 overall. Here are the results of testing the la