[collections] CollectionUtils factory methods for Synchronized, Unmodifiable collections

The factory methods for synchronized and unmodifiable collections use the implementations from java.util.Collections. I assume that these methods predate the decorators package and these should now be changed to use the decorator factories. Any objections to this change? Phil

Re: [collections] submission: KeyValueRecord

> 'Record' confused me and made me think of databases. Is > KeyValueHistory a better name? Stephen, you're probably right. I had been bouncing back and forth between 'Record' and 'History'... the data structure does *record* a kv-pair's *history*, but in fact only the most recent part (one state

[collections] CollectionUtils.index() behavior

Currently, if obj is a Map or a Collection (but not a List) and index is an Integer, CollectionUtils.index(obj,index) will return the index-th object returned by an iterator over the map/collection. Since there is no guaranteed order in these cases, it does not make sense to me for index() to

cvs commit: jakarta-commons-sandbox/primitives/src/codegen/org/apache/commons/primitive/list - New directory

scolebourne2003/09/20 16:46:29 jakarta-commons-sandbox/primitives/src/codegen/org/apache/commons/primitive/list - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-commons-sandbox/primitives/src/codegen/org/apache/commons/primitive/collection - New directory

scolebourne2003/09/20 16:46:28 jakarta-commons-sandbox/primitives/src/codegen/org/apache/commons/primitive/collection - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PRO

cvs commit: jakarta-commons-sandbox/primitives/src/codegen/org/apache - New directory

scolebourne2003/09/20 16:46:28 jakarta-commons-sandbox/primitives/src/codegen/org/apache - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-commons-sandbox/primitives/src/codegen - New directory

scolebourne2003/09/20 16:46:28 jakarta-commons-sandbox/primitives/src/codegen - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [collections] submission: KeyValueRecord

'Record' confused me and made me think of databases. Is KeyValueHistory a better name? DefaultMapEntry IIRC is the simple Map.Entry impl. Stephen PS. I guess this came from the rich events package, which I would like to see as an implementation of the observed code. - Original Message -

RE: [collections] New Collection

On Fri, 2003-09-19 at 12:51, Oxley, David wrote: > Ok. The list won't accept the attachment. If anyone wants to review it, I > will email it to you directly. > Dave. You could attach it to a bugzilla entry which might be easier. -Janek

[collections] submission: KeyValueRecord

Attached is source (& associated tests) for KeyValueRecord.java. KeyValueRecord is an immutable {key, value, previous-value} triplet, a simple but very useful data structure. It's particularly of use with Map (and Map.Entry) for storing, tracking, and comparing entry state, but can obviously be use

Re: [collections] BidiMap / DoubleOrderedMap

Stephen Colebourne wrote: A BidiMap interface has just been checked in as a starter. It has - getKey(Object value) - removeKey(Object value) - inverseBidiMap() I personally prefer Bidi, because its easier to manage simply from length. I think the name needs to be one word, otherwise implementation

cvs commit: jakarta-commons-sandbox/primitives project.xml build.xml

scolebourne2003/09/20 14:11:16 Modified:primitives project.xml build.xml Log: Update build scripts Revision ChangesPath 1.2 +1 -1 jakarta-commons-sandbox/primitives/project.xml Index: project.xml ==

cvs commit: jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/list PrimitiveList.java IntList.java

scolebourne2003/09/20 14:10:34 Modified:primitives/src/java/org/apache/commons/primitive/list PrimitiveList.java IntList.java Log: Tidy List interfaces Revision ChangesPath 1.2 +2 -2 jakarta-commons-sandbox/primitives/src/java/org/apach

Re: [collections] BidiMap / DoubleOrderedMap

A BidiMap interface has just been checked in as a starter. It has - getKey(Object value) - removeKey(Object value) - inverseBidiMap() I personally prefer Bidi, because its easier to manage simply from length. I think the name needs to be one word, otherwise implementation names get confusing. And

cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections BidiMap.java

scolebourne2003/09/20 13:24:30 Added: collections/src/java/org/apache/commons/collections BidiMap.java Log: Initial checkin Revision ChangesPath 1.1 jakarta-commons/collections/src/java/org/apache/commons/collections/BidiMap.jav

Re: [collections] BidiMap / DoubleOrderedMap

On Sat, 20 Sep 2003, Phil Steitz wrote: > See comments inline. > > Stephen Colebourne wrote: > > I have been prompted to take a look at DoubleOrderedMap by bugzilla and been > > a little surprised by what I found. Given the history of collections, what > > we have is a single implementation broug

cvs commit: jakarta-commons-sandbox/io/src/java/org/apache/commons/io/filefilter FileFilterUtils.java TrueFileFilter.java SuffixFileFilter.java FalseFileFilter.java PrefixFileFilter.java AndFileFilter.java NotFileFilter.java OrFileFilter.java

scolebourne2003/09/20 12:52:39 Modified:io/src/java/org/apache/commons/io/filefilter FileFilterUtils.java TrueFileFilter.java SuffixFileFilter.java FalseFileFilter.java PrefixFileFilter.java AndFileFilter.java

Re: [collections] BidiMap / DoubleOrderedMap

See comments inline. Stephen Colebourne wrote: I have been prompted to take a look at DoubleOrderedMap by bugzilla and been a little surprised by what I found. Given the history of collections, what we have is a single implementation brought in from an external project. [collections] should do bet

Re: [collections] BidiMap / DoubleOrderedMap

- Original Message - From: "__matthewHawthorne" <[EMAIL PROTECTED]> > I was thinking that the inverseBidiMap() would just return a reference > to an inner class which is held inside of the BidiMap implementation. This is still another object. Sure it can be cached and the same one returned

Re: [collections] BidiMap / DoubleOrderedMap

I was thinking that the inverseBidiMap() would just return a reference to an inner class which is held inside of the BidiMap implementation. That way there may not have to be another object created. I'm not sure if this is practical or not. It all depends on whether we want to be able to call

Re: [collections] BidiMap / DoubleOrderedMap

I had an inverseBidiMap() to cover the valueMap() case. However I reckon that since the whole reason for the class is to allow the reverse lookup, its not unreasonable to be able to access it directly. Having to go via an inverseBidiMap() method means creating another object, which is quite a large

Re: [collections] BidiMap / DoubleOrderedMap

in SortedBidiMap I made a mistake in SortedBidiMap, my suggested valueMap() would at least have to return a java.util.SortedMap, since java.util.Map doesn't have the headMap, tailMap, and subMap methods. __matthewHawthorne wrote: In BidiMap, instead of: > Object getKeyForValue(Ob

Re: [collections] BidiMap / DoubleOrderedMap

In BidiMap, instead of: > Object getKeyForValue(Object value) > Object removeValue(Object value) > Set entrySetByValue() > Set keySetByValue() > Collection valuesByValue() What about just providing a single method which would return a Map with the k

DO NOT REPLY [Bug 23291] - impossible to turn off all validation tests when a validationQuery is present

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-commons/dbcp/src/test/org/apache/commons/dbcp TestBasicDataSource.java

dirkv 2003/09/20 10:31:38 Modified:dbcp/src/test/org/apache/commons/dbcp TestBasicDataSource.java Log: Bugzilla Bug 23291: impossible to turn off all validation tests when a validationQuery is present => junit test Revision ChangesPath 1.12

cvs commit: jakarta-commons/dbcp/src/java/org/apache/commons/dbcp BasicDataSource.java

dirkv 2003/09/20 10:31:05 Modified:dbcp/src/java/org/apache/commons/dbcp BasicDataSource.java Log: Bugzilla Bug 23291 impossible to turn off all validation tests when a validationQuery is present Revision ChangesPath 1.28 +13 -10 jakarta-commons/dbcp/src/ja

cvs commit: jakarta-commons/dbcp/src/java/org/apache/commons/dbcp BasicDataSource.java

dirkv 2003/09/20 10:11:25 Modified:dbcp/src/java/org/apache/commons/dbcp BasicDataSource.java Log: codestyle cleanup, no change Revision ChangesPath 1.27 +36 -52 jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java Index: BasicDataSou

cvs commit: jakarta-commons/collections/src/test/org/apache/commons/collections/decorators TestPredicatedCollection.java TestTypedBag.java TestPredicatedSortedBag.java TestPredicatedBuffer.java TestLazySortedMap.java TestPredicatedList.java TestPredicatedSortedMap.java TestLazyMap.java TestPredicatedBag.java TestTypedSortedBag.java TestPredicatedSet.java TestPredicatedMap.java TestBlockingBuffer.java

scolebourne2003/09/20 10:05:37 Modified:collections/src/test/org/apache/commons/collections/decorators TestPredicatedCollection.java TestTypedBag.java TestPredicatedSortedBag.java TestPredicatedBuffer.java TestLazySo

cvs commit: jakarta-commons/collections/src/test/org/apache/commons/collections TestBufferUtils.java TestListUtils.java TestSetUtils.java TestMapUtils.java TestExtendedProperties.java TestBagUtils.java TestReferenceMap.java TestHashBag.java TestTreeBag.java

scolebourne2003/09/20 10:02:03 Modified:collections/src/test/org/apache/commons/collections TestBufferUtils.java TestListUtils.java TestSetUtils.java TestMapUtils.java TestExtendedProperties.java TestBagUtils.java

cvs commit: jakarta-commons/collections/src/test/org/apache/commons/collections TestList.java

scolebourne2003/09/20 10:00:32 Modified:collections/src/test/org/apache/commons/collections TestList.java Log: Strengthen test Revision ChangesPath 1.20 +12 -4 jakarta-commons/collections/src/test/org/apache/commons/collections/TestList.j

DO NOT REPLY [Bug 23293] - setAutoCommit(true) when returning connection to the pool

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-commons/dbcp/src/test/org/apache/commons/dbcp TestBasicDataSource.java

dirkv 2003/09/20 09:59:41 Modified:dbcp/src/test/org/apache/commons/dbcp TestBasicDataSource.java Log: Bugzilla Bug 23293: setAutoCommit(true) when returning connection to the pool - Giving a hint to the database driver that you don't need long running t

cvs commit: jakarta-commons/dbcp/src/java/org/apache/commons/dbcp PoolableConnectionFactory.java

dirkv 2003/09/20 09:59:15 Modified:dbcp/src/java/org/apache/commons/dbcp PoolableConnectionFactory.java Log: Bugzilla Bug 23293: setAutoCommit(true) when returning connection to the pool - Giving a hint to the database driver that you don't need long runni

cvs commit: jakarta-commons/collections/src/test/org/apache/commons/collections TestAll.java

scolebourne2003/09/20 09:58:19 Modified:collections/src/test/org/apache/commons/collections TestAll.java Log: Make tests alphabetical and grouped Revision ChangesPath 1.47 +15 -14 jakarta-commons/collections/src/test/org/apache/commons/col

cvs commit: jakarta-commons/collections/src/test/org/apache/commons/collections/decorators TestOrderedSet.java

scolebourne2003/09/20 09:57:47 Modified:collections/src/java/org/apache/commons/collections/decorators OrderedSet.java collections/src/test/org/apache/commons/collections/decorators TestOrderedSet.java Log: Enhance Ordere

cvs commit: jakarta-commons/collections/src/test/org/apache/commons/collections/decorators TestAll.java

scolebourne2003/09/20 09:57:20 Modified:collections/src/test/org/apache/commons/collections/decorators TestAll.java Log: Make tests alphabetical Revision ChangesPath 1.15 +9 -5 jakarta-commons/collections/src/test/org/apache/commons/coll

DO NOT REPLY [Bug 23293] New: - setAutoCommit(true) when returning connection to the pool

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DBCP should not be writing messages to stderr or stdout

> DBCP should not be writing messages to stderr or stdout > [EMAIL PROTECTED] changed: > Resolution||WONTFIX > Like Shankar said, we should only add a dependency on a logging > package if really needed. > We could consider making more use of the logwriter on t

DO NOT REPLY [Bug 22826] - [collections] List/Set implementation.

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 22826] - [collections] List/Set implementation.

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 23291] New: - impossible to turn off all validation tests when a validationQuery is present

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 22776] - DBCP should not be writing messages to stderr or stdout

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-commons-sandbox/attributes/unittest/src/test/org/apache/commons/attributes/test AttributesTestCase.java Sample.java SampleIF1.java

leosutic2003/09/20 08:11:34 Modified:attributes project.xml attributes/api/src/java overview.html attributes/api/src/java/org/apache/commons/attributes Attributes.java CachedRepository.java DefaultCachedReposit

DO NOT REPLY [Bug 23185] - PoolableConnection.close() won't allow multiple close

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: [HiveMind] CentralEventService

I forgot to mention two more points why I preferre the call from the outside aproach: If you register in the initialize method and the service is deferred the Listeners are registered not until the Service is the first time used and than it may be to late. Second if the service-type is per thr

DO NOT REPLY [Bug 23157] - add defaultCatalog to BasicDataSource

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-commons/dbcp/src/test/org/apache/commons/dbcp TestBasicDataSource.java

dirkv 2003/09/20 07:29:59 Modified:dbcp/src/test/org/apache/commons/dbcp TestBasicDataSource.java Log: Bugzilla Bug 23157: add defaultCatalog to BasicDataSource - junit test: testDefaultCatalog Revision ChangesPath 1.10 +29 -3 jakarta

cvs commit: jakarta-commons/dbcp/src/java/org/apache/commons/dbcp BasicDataSource.java BasicDataSourceFactory.java PoolableConnectionFactory.java

dirkv 2003/09/20 07:28:55 Modified:dbcp/src/java/org/apache/commons/dbcp BasicDataSource.java BasicDataSourceFactory.java PoolableConnectionFactory.java Log: Bugzilla Bug 23157 add defaultCatalog to BasicDataSource Revision

Re: [collections] deprecate CursorableLinkedList?

This class has been changed, and should now be fully Serializable. (Open cursors are not now serialized) Stephen - Original Message - From: "Simon Kitching" <[EMAIL PROTECTED]> To: "Jakarta Commons Developers List" <[EMAIL PROTECTED]> Sent: Thursday, September 18, 2003 10:41 PM Subject: R

DO NOT REPLY [Bug 23081] - DBCP - Bad DB Validation Query Hangs Everything

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 6934] - SQLTransformer.java - infinite loop in getConnection

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug

cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections MapUtils.java

scolebourne2003/09/20 05:03:52 Modified:collections/src/java/org/apache/commons/collections MapUtils.java Log: Javadoc and code tidying Revision ChangesPath 1.36 +160 -191 jakarta-commons/collections/src/java/org/apache/commons/collections/M

DO NOT REPLY [Bug 23060] - Pool not available for download

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 23270] - [collections] DoubleOreredMap enhancements

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 23092] - [collections] Map.debug/verbosePrint Thread Safety

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-commons/collections/src/test/org/apache/commons/collections TestMapUtils.java

scolebourne2003/09/20 04:26:57 Modified:collections/src/test/org/apache/commons/collections TestMapUtils.java Log: Remove System out debugging Revision ChangesPath 1.14 +2 -12 jakarta-commons/collections/src/test/org/apache/commons/collec

cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections MapUtils.java

scolebourne2003/09/20 04:26:33 Modified:collections/src/java/org/apache/commons/collections MapUtils.java Log: Make MapUtils threadsafe and remove synchronized keyword. Change is partially backwards incompatible: - protected method is removed - two threa

RE: [HIVEMIND] Why Javassist?

Absolutely; if you look at the ServiceInterceptorFactory interface, there's no mention of Javassist or the ClassFactory service. The implementations chose to do it this way; I think inside the unit tests, the Count service may still be implemented using proxies. -- Howard M. Lewis Ship Creator,

DO NOT REPLY [Bug 23041] - [collections][PATCH] OutOfMemoryError test case for MapUtils.verbosePrint.

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-commons/lang build.xml STATUS.html

scolebourne2003/09/20 03:18:56 Modified:lang build.xml STATUS.html Removed: lang/src/test/org/apache/commons/lang/reflect/priv PackageBean.java PrivateIndirect.java PrivateBeanFactory.java PrivateBean.java

DO NOT REPLY [Bug 6934] - SQLTransformer.java - infinite loop in getConnection

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug