[lang][patch] JUnit Coverage Patch

2005-08-11 Thread Nathan Beyer
Patches to increase test coverage. -Nathan Index: src/test/org/apache/commons/lang/time/DateFormatUtilsTest.java === --- src/test/org/apache/commons/lang/time/DateFormatUtilsTest.java (revision 230932) +++

[lang][patch] Small clean patch in base Utils

2005-08-11 Thread Nathan Beyer
Some small changes to ClassUtils and StringUtils. -Nathan Index: src/java/org/apache/commons/lang/ClassUtils.java === --- src/java/org/apache/commons/lang/ClassUtils.java(revision 230932) +++

[lang][patch] FastDateFormat Serialization Patch

2005-08-11 Thread Nathan Beyer
This patch allows for FastDateFormat to be Serializable; since the Rule objects stored as instance variables werent Serializable, this would fail at runtime. -Nathan Index: src/java/org/apache/commons/lang/time/FastDateFormat.java

[lang] serialVersionUID for Exception classes

2005-08-08 Thread Nathan Beyer
Is there any particular reason that the Exception classes in the lang project don't define their own serialVersionUID fields? Exceptions are inherently serializable and I've always considered adding serialVersionUID fields to serializable classes a must for protecting future compatability.

[lang][patch] NestableDelegate Small Test Increase and Optimization

2005-08-04 Thread Nathan Beyer
The attached patch slightly increments the test coverage for NestableDelegate. It also includes a small rework of the getMessage() method to minimize StringBuffer creation. The application of the latter piece is up to the discretion of the committers, obviously. -Nathan Beyer

[lang][patch] Test and fix for StrBuilder#reverse()

2005-08-01 Thread Nathan Beyer
I also put a change in the patch file to rename the method toStringBuffer in the JUnit to testStringBuffer, which I think was my mistake in the first place. -Nathan Index: src/test/org/apache/commons/lang/text/StrBuilderTest.java

[lang][patch] Test and fix for StrBuilder#indexOf and #lastIndexOf methods

2005-08-01 Thread Nathan Beyer
Some more test patches (and fixes). This should get the indexOf and lastIndexOf methods. -Nathan Index: src/test/org/apache/commons/lang/text/StrBuilderTest.java === --- src/test/org/apache/commons/lang/text/StrBuilderTest.java

[lang][patch] Tests for math sub-package (was RE: [lang] Better coverage for StrBuilder and StrTokenizer.)

2005-07-31 Thread Nathan Beyer
Here are some additional patches for the 'math' sub-package. The second attachment is a new test file, since there wasn't a file just for testing the Range class's base methods. -Original Message- From: Gary Gregory [mailto:[EMAIL PROTECTED] Sent: Saturday, July 30, 2005 6:58 PM To:

RE: [lang][patch] Tests for math sub-package (was RE: [lang] Better coverage for StrBuilder and StrTokenizer.)

2005-07-31 Thread Nathan Beyer
Missed the other attachment. -Original Message- From: Nathan Beyer [mailto:[EMAIL PROTECTED] Sent: Sunday, July 31, 2005 4:21 PM To: 'Jakarta Commons Developers List' Subject: [lang][patch] Tests for math sub-package (was RE: [lang] Better coverage for StrBuilder and StrTokenizer

RE: [lang] Better coverage for StrBuilder and StrTokenizer.

2005-07-30 Thread Nathan Beyer
I'm willing to do some JUnit building. Any other areas that need more testing? I presume you're working off the main trunk. -Original Message- From: Gary Gregory [mailto:[EMAIL PROTECTED] Sent: Saturday, July 30, 2005 12:18 PM To: Jakarta Commons Developers List Subject: [lang] Better

RE: [lang] Better coverage for StrBuilder and StrTokenizer.

2005-07-30 Thread Nathan Beyer
Attached is a patch with some additional StrBuilder tests and some small fixes. I'll try to put some more together later. -Original Message- From: Nathan Beyer [mailto:[EMAIL PROTECTED] Sent: Saturday, July 30, 2005 3:57 PM To: 'Jakarta Commons Developers List' Subject: RE: [lang