Patches to fix the caught Throwables. And a test case. And change build.xml to use junit 3.7. Fairly important, since this is supposed to be compatible with jdk 1.4, and assert is now a keyword.
> -----Original Message----- > From: Steve Downey > Sent: Monday, February 04, 2002 4:30 PM > To: 'Jakarta Commons Developers List' > Subject: RE: Problems with commons-logging > > > BTW, another issue I just saw: > catch(Throwable) {} > > Is it really the intent to catch OutOfMemoryError, and do nothing? > > Or, you really want to keep the thread from cleaning up when > thread.stop() > is called (ThreadDeath)? > > Throwable is not shorthand for "list of exceptions I mean to catch". > Catching Throwable means "I'll handle every possible thing > that goes wrong, > up to and including VM bugs, like InternalError" > > Just because it seems unlikely to happen in the block of code you are > calling, doesn't mean that it won't eventually happen. > >
commons-logging-exceptions.patch
Description: Binary data
TestLogSource.java
Description: Binary data
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>