Re: [VOTE] Release Commons FileUpload 1.1

2005-12-21 Thread Niall Pemberton
-- -- [X] +1 Release Commons FileUpload 1.1-RC2 as Commons FileUpload 1.1 [ ] +0 not too fussed, but OK [ ] -0 won't block, but think imperfect [ ] -1 not until xxx is fixed The only co

Re: [VOTE] Release Commons FileUpload 1.1

2005-12-21 Thread robert burrell donkin
On Wed, 2005-12-21 at 09:09 -0800, Martin Cooper wrote: > On 12/21/05, robert burrell donkin <[EMAIL PROTECTED]> > wrote: > > > > hi martin > > > > does fileupload required 1.4 JDK or higher? > > > From project.properties: > > maven.compile.source=1.3 > maven.compile.target=1.3 just checking si

Re: [VOTE] Release Commons FileUpload 1.1

2005-12-21 Thread Martin Cooper
On 12/21/05, robert burrell donkin <[EMAIL PROTECTED]> wrote: > > hi martin > > does fileupload required 1.4 JDK or higher? >From project.properties: maven.compile.source=1.3 maven.compile.target=1.3 -- Martin Cooper (probably the minimum JDK is probably something we should start adding > to

Re: [VOTE] Release Commons FileUpload 1.1

2005-12-21 Thread robert burrell donkin
hi martin does fileupload required 1.4 JDK or higher? (probably the minimum JDK is probably something we should start adding to the release notes.) - robert On Mon, 2005-12-19 at 22:54 -0800, Martin Cooper wrote: > While the vote on Release Candidate 1 passed, I have taken the time to clean > u

Re: [VOTE] Release Commons FileUpload 1.1

2005-12-20 Thread Martin van den Bemt
+1.. Mvgr, Martin Martin Cooper wrote: While the vote on Release Candidate 1 passed, I have taken the time to clean up all of the minor issues reported against that candidate build, and to modify the jar manifest to adhere to recently discussed Commons conventions. This vote, therefore, is on

[VOTE] Release Commons FileUpload 1.1

2005-12-19 Thread Martin Cooper
While the vote on Release Candidate 1 passed, I have taken the time to clean up all of the minor issues reported against that candidate build, and to modify the jar manifest to adhere to recently discussed Commons conventions. This vote, therefore, is on whether or not the FileUpload 1.1-RC2 build

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-12 Thread Martin Cooper
On 12/11/05, Phil Steitz <[EMAIL PROTECTED]> wrote: > > +1 Looks good. > > One nit, which is not worth -0 IMHO, but which you might consider. > Both bin and src distros unpack to the same directory. Some people > prefer the src distro to unpack to -src. I did consider this, and swithered about

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-12 Thread Martin Cooper
On 12/11/05, Rahul Akolkar <[EMAIL PROTECTED]> wrote: > > +1 > > I would, however, like to see the deprecations issued in IO 1.1 > removed from the fileupload 1.1 sources. A (minor) patch to that > effect is available for consideration in bugzilla, item 37865 [1]. Thanks. Fixed. -- Martin Cooper

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-11 Thread Rahul Akolkar
+1 I would, however, like to see the deprecations issued in IO 1.1 removed from the fileupload 1.1 sources. A (minor) patch to that effect is available for consideration in bugzilla, item 37865 [1]. -Rahul [1] http://issues.apache.org/bugzilla/show_bug.cgi?id=37865 On 12/11/05, Martin Cooper <

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-11 Thread Phil Steitz
+1 Looks good. One nit, which is not worth -0 IMHO, but which you might consider. Both bin and src distros unpack to the same directory. Some people prefer the src distro to unpack to -src. This could be accomplished by adding to the end of your postGoal on dist:prepare-src-filesyst

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-11 Thread Martin Cooper
On 12/10/05, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > +1 from me - I have the following minor comments: > > 1) On the "Issue Tracking" page the "Submit a Bug" link puts an "[io]" > prefix in the header rather than "[fileupload]". Fixed. 2) The links on the "Changes/Developer Activity/File

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-11 Thread Torsten Curdt
+0 cheers -- Torsten PGP.sig Description: This is a digitally signed message part

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-11 Thread Rory Winston
+1 Don Brown wrote: +0 On 12/10/05, Martin Cooper <[EMAIL PROTECTED]> wrote: A new release of Commons FileUpload is long overdue, to say the least, and I believe it's ready. The remaining issues are either enhancements or pending further input. The distributions for FileUpload 1.1 Release

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-11 Thread Don Brown
+0 On 12/10/05, Martin Cooper <[EMAIL PROTECTED]> wrote: > > A new release of Commons FileUpload is long overdue, to say the least, and > I > believe it's ready. The remaining issues are either enhancements or > pending > further input. The distributions for FileUpload 1.1 Release Candidate 1 > ar

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-11 Thread Stephen Colebourne
Niall Pemberton wrote: 3) I upgraded the Struts 1.2.8 example webapp with no problems, except I initially forgot to add the new Commons IO dependency - IMO it would be worth mentioning this in the official announcement if/when the 1.1 release is approved. And this is why I will give it a -0. My o

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-11 Thread Martin van den Bemt
+1.. There are just too many fixes since 2003 to NOT release :) Mvgr, Martin Martin Cooper wrote: A new release of Commons FileUpload is long overdue, to say the least, and I believe it's ready. The remaining issues are either enhancements or pending further input. The distributions for FileUpl

Re: [VOTE] Release Commons FileUpload 1.1-RC1

2005-12-10 Thread Niall Pemberton
+1 from me - I have the following minor comments: 1) On the "Issue Tracking" page the "Submit a Bug" link puts an "[io]" prefix in the header rather than "[fileupload]". 2) The links on the "Changes/Developer Activity/File Activity" report don't work - this is a bug in the maven plug-in - but cha

[VOTE] Release Commons FileUpload 1.1-RC1

2005-12-10 Thread Martin Cooper
A new release of Commons FileUpload is long overdue, to say the least, and I believe it's ready. The remaining issues are either enhancements or pending further input. The distributions for FileUpload 1.1 Release Candidate 1 are now available here: http://people.apache.org/~martinc/fileupload/v1.1