[email] Findbugs

2005-08-25 Thread Henning P. Schmiedehausen
Hi, I've added a findbugs task to the email build and it has a few things to report. We might discuss a little bit whether it is worth to work on this: Email.java 911, 926: externally mutable object This is correct. The date object could be changed after it was put into the Email object.

Re: [email] Findbugs

2005-08-25 Thread Eric Pugh
Digging into it, I don't really get the setSendDate() being public either. I lean towards it being private as well. Also, why can't we return null? The logic in getSendDate() seems odd.. If you haven't sent the email, then it should be null: public Date getSentDate(){ return