[jira] Commented: (IO-99) FileCleaner thread never ends and cause memory leak in AS

[ http://issues.apache.org/jira/browse/IO-99?page=comments#action_12461277 ] Jochen Wiedmann commented on IO-99: --- I have reviewed Stephen's patch and it looks good to me. Only minor note: I'd recommend to make getTrackCount() synchronized.

[jira] Commented: (IO-99) FileCleaner thread never ends and cause memory leak in AS

[ http://issues.apache.org/jira/browse/IO-99?page=comments#action_12455943 ] Jochen Wiedmann commented on IO-99: --- I have added the following section to the FileUpload docs. It seems worth mentioning here, because it confirms Martins concerns:

[jira] Commented: (IO-99) FileCleaner thread never ends and cause memory leak in AS

[ http://issues.apache.org/jira/browse/IO-99?page=comments#action_12455821 ] Henri Yandell commented on IO-99: - I've attached the code needed to FILEUPLOAD-120; if you could give that a shot Vera and let us know if it solves your problem it

[jira] Commented: (IO-99) FileCleaner thread never ends and cause memory leak in AS

[ http://issues.apache.org/jira/browse/IO-99?page=comments#action_12455486 ] Stephen Colebourne commented on IO-99: -- Please review and try the latest code in SVN. FileCleaner thread never ends and cause memory leak in AS

[jira] Commented: (IO-99) FileCleaner thread never ends and cause memory leak in AS

[ http://issues.apache.org/jira/browse/IO-99?page=comments#action_12455206 ] Stephen Colebourne commented on IO-99: -- The simple solution is to add a method exitWhenFinished() that sets a boolean flag. The reaper thread then checks the

[jira] Commented: (IO-99) FileCleaner thread never ends and cause memory leak in AS

[ http://issues.apache.org/jira/browse/IO-99?page=comments#action_12451376 ] Vera Mickaël commented on IO-99: Thanks everybody for your interest in this issue. I've talked about this issue with a developper mastering classloaders problems. It

[jira] Commented: (IO-99) FileCleaner thread never ends and cause memory leak in AS

[ http://issues.apache.org/jira/browse/IO-99?page=comments#action_12450687 ] Vera Mickaël commented on IO-99: I don't know if a daemon thread prevents a classloader from being garbaged ? I worked for several days on classloader leaks,

[jira] Commented: (IO-99) FileCleaner thread never ends and cause memory leak in AS

[ http://issues.apache.org/jira/browse/IO-99?page=comments#action_12450870 ] Henri Yandell commented on IO-99: - Thanks for the reply Vera; please don't take my comment as a negative view. Definitely a good idea to bring it up to the

[jira] Commented: (IO-99) FileCleaner thread never ends and cause memory leak in AS

[ http://issues.apache.org/jira/browse/IO-99?page=comments#action_12450929 ] Martin Cooper commented on IO-99: - It would make sense to me for FileCleaner to provide a method to cleanly stop the reaper thread, and possiby another method to

[jira] Commented: (IO-99) FileCleaner thread never ends and cause memory leak in AS

[ http://issues.apache.org/jira/browse/IO-99?page=comments#action_12450487 ] Henri Yandell commented on IO-99: - The static initializer for FileCleaner: static { reaper.setPriority(Thread.MAX_PRIORITY);