[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514940
 ] 

Paul Benedict edited comment on FILEUPLOAD-141 at 7/24/07 4:12 AM:
-------------------------------------------------------------------

That's why it should be an option. Adding a boolean property to control this 
behavior would be a minor enhancement. I've seen this issue come up before in 
server environments, so this request is definitely not unusual. And in fact, 
this would be a feature I would want to use often with my own customers. To 
have it supported officially by Commons Upload would be beneficial and, I 
think, warranted.


 was:
That's why it should be an option. Adding a boolean property to control this 
behavior would be a minor enhancement.

> Remove FileItems if FileUploadBase.parseRequest() fails
> -------------------------------------------------------
>
>                 Key: FILEUPLOAD-141
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-141
>             Project: Commons FileUpload
>          Issue Type: Improvement
>    Affects Versions: 1.2
>         Environment: commons-fileupload is used for parsing 
> multipart/form-data POST requests in servlets.
> OS: Linux
>            Reporter: Marcus Klein
>
> If the method FileUploadBase.parseRequest() throws a FileUploadException, the 
> already parsed FileItem objects are not accessible and removed by the garbage 
> collector. Now expect a fileupload that fills the servers hard disc with 
> FileItems until no space is left on the device. The method parseRequest() 
> throws a FileUploadException and there are several FileItem objects that 
> still exist in the device because the garbage collector does not run and 
> removes them. This causes failing fileuploads until the garbage collector 
> runs and removes the lost FileItem objects. I suggest calling 
> FileItem.delete() on all FileItem objects created in the method 
> FileUploadBase.parseRequest() if the method is left with a 
> FileUploadException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to