[ https://issues.apache.org/jira/browse/BEANUTILS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton resolved BEANUTILS-283. --------------------------------------- Resolution: Fixed Fix Version/s: 1.8.0 Assignee: Niall Pemberton I've fixed this and added a test case using the DateConverter: http://svn.apache.org/viewvc?view=rev&revision=546174 Thanks for providing the demonstration of the issue - as a side note the DateConverter has been re-factored and you can create and register it to use a specified Locale - either with the default (SHORT) pattern for that locale or for a specified pattern or set of patterns. > ConvertUtilsBean doesn't handl conversion to String correctly > ------------------------------------------------------------- > > Key: BEANUTILS-283 > URL: https://issues.apache.org/jira/browse/BEANUTILS-283 > Project: Commons BeanUtils > Issue Type: Bug > Components: ConvertUtils & Converters > Affects Versions: Nightly Builds > Environment: commons-beanutils-20070610-src.zip > Reporter: Josef Cacek > Assignee: Niall Pemberton > Fix For: 1.8.0 > > Attachments: Test.java > > > Either lookup(Class, Class) or convert(Object, Class) method doesn't work > correctly in class ConvertUtilsBean. > Problematic is the case when target class is String. > The code from convert(..) which doesn't work: > Object converted = value; > Converter converter = lookup(sourceType, targetType); > if (converter != null) { > if (log.isTraceEnabled()) { > log.trace(" Using converter " + converter); > } > converted = converter.convert(targetType, value); > } > // here we already have converted value (String), but we will rewrite it by > default .toString() - it's a bug > if (targetType == String.class && value != null) { > converted = value.toString(); > } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]